Improve logger (deduping, new help and version) #2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ded20ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
natemoo-re
commented
Mar 9, 2022
tony-sull
reviewed
Mar 9, 2022
natemoo-re
changed the title
|
LGTM! can we merge after #2705 ? |
Yep, that's the plan! |
matthewp
approved these changes
Mar 9, 2022
natemoo-re
force-pushed
the
feat/improve-logger
branch
3 times, most recently
from
a86303a
to
361fe5b
Compare
added 12 commits
March 9, 2022 17:04
natemoo-re
force-pushed
the
feat/improve-logger
branch
from
361fe5b
to
651501b
Compare
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* feat: improve logger by removing repeat messages * feat(hmr): only send HMR updates when files change * feat: improve hmr formatting * feat(logger): improve welcome formatting * feat(logger): improve hmr formatting * chore(test): update cli test output * feat(logger): improve logging output * feat(logger): improve help/version flags * chore: remove checksum checks * fix(test): update cli tests * refactor(test): cleanup astro dev cli tests * chore: add changeset * chore(test): skip doctype test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
(x2)to the end of duplicatesupdateorreloadmessagesastro --helpoutput to match new logging styleastro --versionoutput to match new logging styleOld HMR
New HMR
New Help
On wide terminals
On tall terminals
New Version
Testing
Tested manually + CLI tests updated
Docs
N/A