Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sitemap filter option #2755

Merged
merged 4 commits into from Mar 10, 2022
Merged

Add sitemap filter option #2755

merged 4 commits into from Mar 10, 2022

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Mar 10, 2022

Changes

  • Adds sitemapFilter option to our config. This is likely a temporary option until integrations are sorted out.
  • Follow-up to Add filter for sitemap #2562

Testing

N/A, no sitemap tests

Docs

Config docs are JS-doc driven

@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2022

🦋 Changeset detected

Latest commit: 86fac26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 10, 2022
@FredKSchott
Copy link
Member

Not blocking: I'm 👍 with this as a short-term fix, but wanted to make sure we spin up a discussion on future plans since I don't necessarily agree with how you've phrased the OP around "until we have better sitemap support via non-HTML dynamic routes."

Discussion started here: withastro/roadmap#146

@natemoo-re natemoo-re merged commit 10843ab into main Mar 10, 2022
@natemoo-re natemoo-re deleted the feat/sitemap-filter branch March 10, 2022 20:14
@github-actions github-actions bot mentioned this pull request Mar 10, 2022
@github-actions github-actions bot mentioned this pull request Mar 11, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Add filter for sitemap

* chore: add changeset

* fix: types

* docs: add sitemapFilter docs

Co-authored-by: David Rothmann <david@rothmann.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants