Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow SSR dynamic routes to not implement getStaticPaths #2815

Merged
merged 3 commits into from Mar 17, 2022
Merged

Allow SSR dynamic routes to not implement getStaticPaths #2815

merged 3 commits into from Mar 17, 2022

Conversation

matthewp
Copy link
Contributor

Changes

  • Dynamic routes in SSR should not have to implement getStaticPaths, since these routes are completely dynamic.
  • This allows that.

Testing

  • First SSR test (woot)

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2022 •
edited

🦋 Changeset detected

Latest commit: aea34dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) test labels Mar 16, 2022
natemoo-re
natemoo-re reviewed Mar 16, 2022
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small refactors could clean this up, but this is amazing!

examples/ssr/src/pages/products/[id].astro Show resolved Hide resolved
packages/astro/src/core/render/route-cache.ts Outdated Show resolved Hide resolved
packages/astro/src/core/render/route-cache.ts Outdated Show resolved Hide resolved
packages/astro/src/core/routing/validation.ts Outdated Show resolved Hide resolved
@matthewp matthewp merged commit 7b9d042 into main Mar 17, 2022
@matthewp matthewp deleted the no-get-static-paths branch March 17, 2022 12:31
@github-actions github-actions bot mentioned this pull request Mar 17, 2022
Merged
@github-actions github-actions bot mentioned this pull request Mar 25, 2022
Merged
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@matthewp
Allow SSR dynamic routes to not implement getStaticPaths (withastro#2815
2a33efc 
)

* Allow SSR dynamic routes to not implement getStaticPaths

* Adds a changeset

* Update based on code-review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re left review comments

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthewp @natemoo-re