Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable custom element test and fix "undefined" child #3095

Merged
merged 3 commits into from
Apr 13, 2022
Merged

Conversation

matthewp
Copy link
Contributor

Changes

  • Closes fix build base bug #3068
  • Prevents rendering "undefined" as a child of custom elements
  • Re-enables the custom elements tests, which were disabled during the integrations migration.

Testing

  • Tests re-enabled / migrated
  • New test for this case

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2022

🦋 Changeset detected

Latest commit: c8f1281

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
astro Patch
@astrojs/webapi Patch
astro-scripts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) test labels Apr 12, 2022
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not as confident with the webapi changes, but undefineitely LGTM 👏

@FredKSchott
Copy link
Member

LGTM! I think you mean that this closes #3070, not #3068

@matthewp matthewp merged commit 5acf77d into main Apr 13, 2022
@matthewp matthewp deleted the custom-el-undef branch April 13, 2022 12:44
@github-actions github-actions bot mentioned this pull request Apr 13, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Re-enable custom element test and fix "undefined" child

* Remove outdated comment

* Adds a changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants