Fixing bug that could lose Tailwind's default presets #3099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3dd7473 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
Merged
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* fixing bug that could lose Tailwind's default presets * updating integration README * chore: adding changeset * test: fixing the tailwind tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #3043
@astrojs/tailwindwas defaulting presets to[]which actually tells Tailwind to remove the default presets of colors, sizes, etc.This change removes the
applyAstroConfigPresetoption, instead of our own custom flag users can disable the built-in preset in the Tailwind config as usual by includingpresets: []themselvesTesting
Docs
Updated the integration README (no docs site updates needed)
Bug details
Forcing
presets: undefinedin our default Tailwind config makes sure that the presets are enabled by default. What was happening in #3043 is that the user config customized the theme and didn't include thepresetsconfig option (pretty normal not to use that option). Our integration ended up with a customized theme andpresets: [], which inadvertantly threw out all Tailwind presets.With this update, users can use their own Tailwind config file to disable presets if they really need to