Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netlify Edge: forward requests for static assets #3170

Merged
merged 3 commits into from
Apr 22, 2022
Merged

Conversation

matthewp
Copy link
Contributor

Changes

  • This includes static assets in the SSR manifest so that adapters can use that.
  • Netlify Edge is called before static assets are handled, so we need to know what static assets exist and not respond. This is in case you have something like [...stuff].astro as a root page, which would capture all requests.

Testing

  • Test added!

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Apr 21, 2022

🦋 Changeset detected

Latest commit: db31d6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
astro Patch
@astrojs/netlify Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) labels Apr 21, 2022
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@matthewp matthewp merged commit 19667c4 into main Apr 22, 2022
@matthewp matthewp deleted the netlify-static-dynamic branch April 22, 2022 14:03
@github-actions github-actions bot mentioned this pull request Apr 22, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Netlify Edge: forward requests for static assets

* Adds a changeset

* Don't run edge tests, yet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants