fix(markdown): file.url fixes

[JuanM04]

Changes

• file.url now respects trailingSlash, adding a / at the end when it's set to "always"
• file.url now respects base (needed to change the default of base from ./ to /)
• Minor fix to this RegEx:

- fileId.replace(/^.*\/pages\//, sitePathname)
+ fileId.replace(/^.*?\/pages\//, sitePathname)

The ? makes the selection "lazy", which means that it will replace the shortest match. For example:

const fileId = "src/pages/docs/pages/how-to-create-a-page.md"

console.log(fileId.replace(/^.*?\/pages\//, '')) // docs/pages/how-to-create-a-page.md
console.log(fileId.replace(/^.*\/pages\//, '')) // how-to-create-a-page.md

Testing

Docs

[changeset-bot]

🦋 Changeset detected

Latest commit: bbf612e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[FredKSchott]

LGTM! Would love to see an added test since this feels like something that we could accidentally regress pretty easily

[JuanM04]

@FredKSchott I've added some test and also made it work with base! While doing that, I've changed the default of base from ./ to / (so now, base always starts with a /)

[FredKSchott]

Agreed, that makes way more sense. Most of our tests are testing the default, so if they are passing I have confidence that this change works. Mind confirming that the dev and preview commands work with an example template to be extra sure? If so the LGTM to merge!

[JuanM04]

Mind confirming that the dev and preview commands work with an example template to be extra sure?

I've tried with a few and all seems normal!

[FredKSchott]

woo! sgtm