Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new configKeys prop for telemetry #3299

Merged
merged 3 commits into from
May 6, 2022
Merged

Add new configKeys prop for telemetry #3299

merged 3 commits into from
May 6, 2022

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented May 5, 2022

Changes

  • This updates the telemetry so that the shallow AstroConfig keys are tracked. We have found the existing vite key data to be very valuable and intend on sharing it with other maintainers. Adding the rest of these config keys will give us better data on which features are being used.

Testing

Tests updated to reflect the new data structure.

Docs

N/A

This property lets us known which AstroConfig keys are being used, for anonymous telemetry.
@changeset-bot
Copy link

changeset-bot bot commented May 5, 2022

🦋 Changeset detected

Latest commit: 60c23f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
astro Patch
@astrojs/telemetry Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) test labels May 5, 2022
Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a bunch of comments but tbh nothing really blocking. Resolve as you see fit!

@matthewp matthewp merged commit 8021998 into main May 6, 2022
@matthewp matthewp deleted the config-props branch May 6, 2022 13:22
@github-actions github-actions bot mentioned this pull request May 6, 2022
nonphoto pushed a commit to nonphoto/astro that referenced this pull request May 6, 2022
* Add new configKeys prop for telemetry

This property lets us known which AstroConfig keys are being used, for anonymous telemetry.

* Adds a changeset

* Restructure how the telemetry event is shaped
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Add new configKeys prop for telemetry

This property lets us known which AstroConfig keys are being used, for anonymous telemetry.

* Adds a changeset

* Restructure how the telemetry event is shaped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants