Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[create-astro] Finalize developer experience... with gradients 馃殌 #3313

Merged
merged 7 commits into from
May 11, 2022

Conversation

bholmesdev
Copy link
Contributor

Changes

astro-cli-rocket.mov
  • Add rocket gradient to "cloning template" and "installing dependencies" steps 馃殌
  • Update "next steps" wording for beginner-friendliness
    • Remove copy-paste snippet in favor of quick explainers. Already wasn't copy-pasteable since we suggested "npm install" for those that opted out of the install step, where they may prefer another package manager. There was also feedback (streamer-driven-development!) that "&&" could break in powershell
    • Replace install rec with a yellow warning message: "Remember to install dependencies first!"

Testing

Based on personal spark-joy-ometer. The reading was off the charts!

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented May 6, 2022

馃 Changeset detected

Latest commit: 559992b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: create-astro Related to the `create-astro` package (scope) label May 6, 2022
@bholmesdev bholmesdev changed the title [create-astro] Finalize developer experience (with gradients!) [create-astro] Finalize developer experience... with gradients 馃殌 May 6, 2022
@@ -30,6 +30,7 @@
"dependencies": {
"@types/degit": "^2.8.3",
"@types/prompts": "^2.0.14",
"chalk": "^5.0.1",
Copy link
Contributor Author

@bholmesdev bholmesdev May 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used to render characters by custom hex values for the gradient. This should only add 1-2 KB to the final install size, which was much better than other "gradient generators" on npm. We can also swap out kleur for chalk if we feel really strongly about optimization (kept kleur for consistency with Astro core though)

Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fun!

@bholmesdev bholmesdev merged commit 1a5335e into main May 11, 2022
@bholmesdev bholmesdev deleted the feat/create-astro-anims-and-wording branch May 11, 2022 16:38
@github-actions github-actions bot mentioned this pull request May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: create-astro Related to the `create-astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants