Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix */ breaking HTML comments in Markdown #3477

Merged

Conversation

hippotastic
Copy link
Contributor

Changes

Testing

  • I added a new test case to verify the fixed behavior.

Docs

  • No visible change, just a bugfix.

@changeset-bot
Copy link

changeset-bot bot commented May 30, 2022

🦋 Changeset detected

Latest commit: 05d34bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 30, 2022
Copy link
Contributor

@aFuzzyBear aFuzzyBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@bholmesdev could you take a look over this one when you got a second dude 👊

If we can get this in, it would make for a very happy 🦛

Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Siimple, well tested. A commentable effort!

@bholmesdev bholmesdev merged commit 429b65d into withastro:main May 30, 2022
@github-actions github-actions bot mentioned this pull request May 30, 2022
@hippotastic hippotastic deleted the fix/markdown-js-in-html-comment branch May 30, 2022 16:54
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: HTML comments in Markdown containing */ anywhere break the compiler
3 participants