Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alias astro to @types/astro #3503

Merged
merged 4 commits into from
Jun 2, 2022

Conversation

williamtetlow
Copy link
Contributor

@williamtetlow williamtetlow commented Jun 2, 2022

Changes

fixes: withastro/compiler#378

Aliases imports for astro to @types/astro c8816d4 and updates Netlify and Deno integrations to handle vite.resolve.alias as an array b15ca78

Only the types live under astro but without alias vite resolves import to packages/astro/astro.js

Testing

  • Test added to check build passes when import type { MarkdownInstance } from 'astro' is present

Docs

No docs needed, this is fix for expected behaviour

@changeset-bot
Copy link

changeset-bot bot commented Jun 2, 2022

🦋 Changeset detected

Latest commit: 7d349c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
astro Patch
@astrojs/deno Patch
@astrojs/netlify Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 2, 2022
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jun 2, 2022
@williamtetlow williamtetlow marked this pull request as ready for review June 2, 2022 16:58
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing fix, thanks for looking into this! 🙌🏻

Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep that's a great catch, looks good to me too!

@natemoo-re natemoo-re merged commit 207f58d into withastro:main Jun 2, 2022
@github-actions github-actions bot mentioned this pull request Jun 2, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* fix: alias astro to @types/astro

* fix: handle resolve.alias being array

* chore: add integrations patch to changeset

* chore: remove empty file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Panic when importing type
3 participants