Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul HMR handling for .astro files #3932

Merged
merged 8 commits into from Jul 22, 2022
Merged

Overhaul HMR handling for .astro files #3932

merged 8 commits into from Jul 22, 2022

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Jul 14, 2022

Changes

  • Overhauls our HMR handling for .astro files, removing much of our custom handling
  • Prioritizes responding with a full page reload over granular updates. Less smooth, but much more reliable
  • We will be looking to layer in granular updates on top of this change post v1.0.0.

Testing

E2E still pass

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Jul 14, 2022

🦋 Changeset detected

Latest commit: c9c11d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 14, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2022

⚖️ Bundle Size Check

Latest commit: c9c11d5

File Old Size New Size Change
hmr 5.42 KB 479 B - NaN undefined

@matthewp
Copy link
Contributor

Description says WIP, is that still true?

Also missing a changeset.

Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just needs a changeset 👍

Great sign that the E2E tests all passed as-is, I think they should cover the basics for HMR updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
3 participants