Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for Astro.clientAddress #3973

Merged
merged 6 commits into from
Jul 19, 2022
Merged

Adds support for Astro.clientAddress #3973

merged 6 commits into from
Jul 19, 2022

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Jul 19, 2022

Changes

  • Adds support for Astro.clientAddress as a way to get the remote IP address of the user making the request. Because there is no standard way to get this information it has to be provided by adapters.
  • Each adapter is updated to support providing this to core rendering throw a symbol on the request object.
  • The implementation is as a getter that throws if the symbol is not provided. This means it will throw if you try to access the property with an adapter that does not support it, or in SSG mode.
  • Closes 🐛 BUG: impossible to get remote client IP address from incoming Astro.request #3708

Testing

  • Tests added for dev and production.
  • Tests added to ensure we throw in SSG mode.

Docs

@changeset-bot
Copy link

changeset-bot bot commented Jul 19, 2022

🦋 Changeset detected

Latest commit: 5dccc59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
astro Minor
@astrojs/cloudflare Minor
@astrojs/deno Minor
@astrojs/netlify Minor
@astrojs/vercel Minor
@astrojs/node Minor
@e2e/astro-component Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) labels Jul 19, 2022
@matthewp matthewp marked this pull request as ready for review July 19, 2022 16:03
@matthewp matthewp merged commit 5a23483 into main Jul 19, 2022
@matthewp matthewp deleted the client-address branch July 19, 2022 20:10
@astrobot-houston astrobot-houston mentioned this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: impossible to get remote client IP address from incoming Astro.request
2 participants