Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSR 404 and 500 routes in adapters #4018

Merged
merged 3 commits into from
Jul 22, 2022
Merged

SSR 404 and 500 routes in adapters #4018

merged 3 commits into from
Jul 22, 2022

Conversation

okikio
Copy link
Member

@okikio okikio commented Jul 21, 2022 •
edited

Changes

(WIP) Add support for 404 and 500 routes in SSR adapters by default

cc @matthewp @bholmesdev I can't figure out how to get the 404 routes correctly

  • What does this change?
  • Be short and concise. Bullet points can help!
  • Before/after screenshots can help as well.
  • Don't forget a changeset! pnpm exec changeset

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2022 •
edited

🦋 Changeset detected

Latest commit: de3d881

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
astro Minor
@astrojs/cloudflare Minor
@astrojs/netlify Minor
@astrojs/vercel Minor
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 21, 2022
@matthewp matthewp self-assigned this Jul 22, 2022
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jul 22, 2022
@matthewp matthewp changed the title fix(WIP): SSR 404 and 500 routes in adapters SSR 404 and 500 routes in adapters Jul 22, 2022
natemoo-re
natemoo-re approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@matthewp matthewp merged commit 0cc6ede into withastro:main Jul 22, 2022
@astrobot-houston astrobot-houston mentioned this pull request Jul 22, 2022
Merged
@okikio okikio mentioned this pull request Jul 22, 2022
Merged
@jablonski jablonski mentioned this pull request Aug 8, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees

@matthewp matthewp

Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@okikio @natemoo-re @matthewp