Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Svelte HMR warning during the build #4057

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Prevent Svelte HMR warning during the build #4057

merged 1 commit into from
Jul 26, 2022

Conversation

matthewp
Copy link
Contributor

Changes

  • This warning is shown in svelte: [vite-plugin-svelte] hmr is enabled but compilerOptions.dev is false, forcing it to true
  • This sets hot to false when not in dev, getting rid of the warning.

Testing

Just manually since it's a warning that can't be easily unit-tested.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2022

🦋 Changeset detected

Latest commit: cec2d73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@astrojs/svelte Patch
@e2e/errors Patch
@e2e/svelte-component Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: integration Related to any renderer integration (scope) labels Jul 26, 2022
@matthewp matthewp merged commit 4025111 into main Jul 26, 2022
@matthewp matthewp deleted the svelte-hmr-warn branch July 26, 2022 18:04
@astrobot-houston astrobot-houston mentioned this pull request Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: svelte Related to Svelte (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants