Fix misc create-astro issues #4075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4b6ef87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: create-astro
Princesseuh
commented
Jul 27, 2022
| @@ -246,7 +312,7 @@ export async function main() { | |||
| )} to your project using ${bold(cyan('astro add'))}` | |||
| ); | |||
| await logAndWait(''); | |||
| await logAndWait(`Stuck? Come join us at ${bold(cyan('https://astro.build/chat'))}`, 1000); | |||
| await logAndWait(`Stuck? Come join us at ${bold(cyan('https://astro.build/chat'))}`, 750); | |||
There was a problem hiding this comment.
Fred talked about a sleep being too long in create-astro, however he didn't specify which one. I can only assume it's this one, which did feel long
matthewp
approved these changes
Jul 27, 2022
tony-sull
approved these changes
Jul 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixed some small misc issues with
create-astro. Polishing, essentially.Fix #3825
Fix #3824 👻😨
Fix #3826
Didn't tackle #3561 in this because I couldn't reproduce it? The peer issue part is unrelated to
create-astroand the main part (pnpm 6not detected) worked for me, not sureTesting
I tried testing some parts of this, but I kept getting weird mocha errors? We don't test much of
create-astroat the moment, so I figured it was fine to not test this for nowDocs
Since this is mostly error handling being done, it doesn't touch the current documentation