Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use passive listeners in prefetch #4207

Merged
merged 3 commits into from
Aug 11, 2022
Merged

Use passive listeners in prefetch #4207

merged 3 commits into from
Aug 11, 2022

Conversation

jablonski
Copy link
Contributor

Without passive=true, Lighthouse complains about not using passive listeners to improve scrolling performance.

Without passive=true, Lighthouse complains about not using passive listeners to improve scrolling performance.
@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2022

🦋 Changeset detected

Latest commit: 90a61d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/prefetch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Aug 9, 2022
Copy link
Contributor

@aFuzzyBear aFuzzyBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @jablonski, Thank you for this very quick fix
💚👊💚

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you!

@natemoo-re natemoo-re merged commit ceb0eef into withastro:main Aug 11, 2022
@astrobot-houston astrobot-houston mentioned this pull request Aug 11, 2022
@jablonski jablonski deleted the patch-1 branch August 11, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants