Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dev server during build #4234

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Remove dev server during build #4234

merged 2 commits into from
Aug 10, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 10, 2022

Changes

Fix #4168

  • Remove starting the dev server during the build process since it's not used anymore
  • Small refactor to remove unused options when passing to collectPagesData

Testing

No new tests added, but should be safe if all current tests pass.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2022

🦋 Changeset detected

Latest commit: edc55c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 10, 2022
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@bluwy bluwy merged commit c38e7f1 into main Aug 10, 2022
@bluwy bluwy deleted the remove-dev-server-build branch August 10, 2022 14:06
@astrobot-houston astrobot-houston mentioned this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧹 Chore: Remove use of Vite dev server from the build
2 participants