Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulate Vite resolve id to url #4239

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Simulate Vite resolve id to url #4239

merged 2 commits into from
Aug 10, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 10, 2022

Changes

Fix #4219

  • Create a util to simulate Vite resolve for /@id and /@fs
  • Correctly resolves modules to be loaded directly via url

Notes:

  • Ideally this should be kept within Vite internally but I haven't found a way for us to do so without a big refactor.
  • I could take a look in Vite to see if it's something we can expose.

Testing

Tested with an example app locally that shows no more sourcemap 404. The refactor should be covered by the existing tests too.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2022

🦋 Changeset detected

Latest commit: 3a634f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 10, 2022
@matthewp matthewp merged commit a9baa45 into main Aug 10, 2022
@matthewp matthewp deleted the fix-sourcemap-url branch August 10, 2022 20:53
@astrobot-houston astrobot-houston mentioned this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 /@id/astro/runtime/client/astro_runtime_client_hmr__js.js.map
2 participants