Update: blog template #4283
Update: blog template #4283
Conversation
|
FredKSchott
force-pushed
the
new-blog-template
branch
from
5df0034
to
1fe65c8
Compare
There was a problem hiding this comment.
"Wow"
This is great, @FredKSchott! A few comments sprinkled throughout. (Namely, let's make sure we remove all references to building a HUGO blog...) but I love it!
| #### Blockquote with attribution | ||
|
|
||
| > Don't communicate by sharing memory, share memory by communicating.<br> | ||
| > — <cite>Rob Pike[^1]</cite> | ||
|
|
||
| [^1]: The above quote is excerpted from Rob Pike's [talk](https://www.youtube.com/watch?v=PAAkCSZUG1c) during Gopherfest, November 18, 2015. |
There was a problem hiding this comment.
Can we update this to something relevant to us? Fred, do you have a favourite moment from a talk?
|
Make sure to run |
| @@ -0,0 +1,25 @@ | |||
| --- | |||
There was a problem hiding this comment.
I understand we want to keep config minimal, but adding an MDX example that doesn't show any MDX features feels a little wrong. If we don't want to add a component integration, that's fair! But at least importing and using .astro component, or accessing frontmatter via JSX expressions, would be helpful.
There was a problem hiding this comment.
Agreed. I had the same thought. I would also add another heading under Usage with a similar very short explanation re: importing and using a component.
We do have the MDX starter already (though not as visible), so this can be just a Markdown starter if we want to go that route. (Is there value in having one?) I do think our "add MDX" path is straightfoward and well-documented enough that I don't worry about people adding it if they want. Just depends what you want people to get by default, using create-astro.
There was a problem hiding this comment.
I had originally put an .astro component with a https://www.npmjs.com/package/canvas-confetti button, but then realized that our Astro.glob() on the blog page was pulling that script into the blog page itself. This is a known side-effect of Astro.glob(), but it felt too problematic to bring into a starter template (at least until we fix it).
I'll do it with one of the existing header links for now.
There was a problem hiding this comment.
Looking great! Agree with the feedback here.
I pushed some updates to the default images to align them with our brand better. Also I have some very small tweaks (adding one media query) to the stylesheet that would enable a dark mode if you're up for it? Didn't want to push that without asking.
Feel free to cherry-pick 3044fec if you want
| Light | Dark |
|---|---|
 |
 |
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
FredKSchott
force-pushed
the
new-blog-template
branch
from
d2e0aaf
to
2ed8106
Compare
|
re dark mode: If the user doesn't see this for themselves, we run the risk of this surprising the developer / not realizing it was supported. I think I'd be +1 if we also added a dark mode toggle to the page UI, but then we'd want to do that without a framework since some of the feedback we got was about this feeling like a "preact template" since it had a preact component in it originally. |
|
Thanks for the feedback everyone! I hate that our current blog template is broken on MDX, so I'm going to merge this so that it's not still broken over the weekend. |
Changes
global.css).Screenshots
Testing
Docs