Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: [@astrojs/image] handle filenames with spaces #4593

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

tony-sull
Copy link
Contributor

Changes

Closes #4582

Fixes a bug that wasn't properly decoding filenames when the path includes spaces

Testing

Tests added for dev/build and SSG/SSR

Docs

bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2022

🦋 Changeset detected

Latest commit: 75c2a42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/image Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Sep 1, 2022
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice tests!

@tony-sull tony-sull merged commit 56f83be into main Sep 1, 2022
@tony-sull tony-sull deleted the fix/image-with-spaces branch September 1, 2022 20:31
@astrobot-houston astrobot-houston mentioned this pull request Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@astrojs/image does not like image paths with spaces in them
2 participants