Parallelize @astrojs/image transforms #4626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8156382 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
altano
commented
Sep 5, 2022
| @@ -40,6 +40,7 @@ | |||
| "test": "mocha --exit --timeout 20000 test" | |||
| }, | |||
| "dependencies": { | |||
| "@altano/tiny-async-pool": "^1.0.2", | |||
There was a problem hiding this comment.
In case anyone is hesitant to take on @altano/tiny-async-pool, a new dependency:
- The used export is super tiny: 315B gzipped
- The package is a fork of async-pool by Rafael Xavier de Souza. I left it MIT licensed and barely modified the code other than to modernize it (typescript, esm export, vitest, etc). The original package gets ~900K weekly downloads so it's mature code and should be fairly bug free.
|
This seems to be trivially faster for small batches of well-behaved transforms as well, not just the pathological case of misbehaved animated gif transforms:
|
matthewp
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Great work! Want to leave it to @tony-sull to take a look at, but it lgtm.
tony-sull
approved these changes
Sep 6, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change parallelizes
@astrojs/imagetransforms to get a big performance boost.@astrojs/imagecurrently processes images serially, one after the other. If it processes 10 images and takes 1 second to process each, the total time will be 10 seconds.This change makes it process images in batches. The batch size is the # of CPUs on the machine, e.g. 8 on my dev machine.
Testing
I manually put the newly built code in dist/build/ssg.js into my current project (I can't figure out how to get
pnpmandnpmto let me link across projects). I then did a before and after build.I then edited
astro.config.mtsand enableddebuglogging:BEFORE - 92 second build
AFTER - 39 second build
NOTE: Yes I know a 92s->39s build time is still abysmal.
@astrojs/imageis very slow at processing animated gifs. I will investigate that separately.Docs
No docs needed as this is a performance improvement