Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure before-hydration is only loaded when used #4768

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Conversation

matthewp
Copy link
Contributor

Changes

  • Previously we were always loading an empty data: script in prod when before-hydration was unused, which is most apps. This required special CSP rules to allow importing data urls.
  • Change is to only load that when it's actually needed by returning an empty string instead and not adding the attribute. Without the attribute the client will not attempt to load it.
  • Fixes Unnecessary data script execution requires unsafe CSP #4762

Testing

  • Test added for every scenario, SSG with and without the use of before-hydration, SSR before and without.

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2022

🦋 Changeset detected

Latest commit: 5adc2b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-cyclic Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/hydration-race Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/solid-recurse Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch
@e2e/third-party-astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 15, 2022
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Great to see that extra data: script ripped out when it isn't used

@matthewp matthewp merged commit 9a59e24 into main Sep 15, 2022
@matthewp matthewp deleted the no-before-hydration branch September 15, 2022 16:33
@astrobot-houston astrobot-houston mentioned this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary data script execution requires unsafe CSP
2 participants