Remove explicit Transfer-Encoding: chunked header
#4807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This header is not necessary and is ignored by essentially all HTTP servers when provided explicitly by the user. This is because the HTTP transport layer handles adding this header automatically as needed. Some variations of HTTP transport (like HTTP/2, which is enabled by default in Deno, Netlify, and CFW) have no notion of `Transfer-Encoding: chunked`, because all responses are streamed.
🦋 Changeset detectedLatest commit: 5ae0f90 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PRtransferencoding_chunked?filename=.changeset/chilly-mails-eat.md&value=---%0A%22astro%22%3A%20patch%0A---%0A%0ARemove%20explicit%20%60Transfer-Encoding%3A%20chunked%60%20header%0A) |
github-actions
bot
added
the
pkg: astro
|
Thanks! Would you mind adding a changeset The failing test is a flakey one, I'll get it reran. |
bluwy
approved these changes
Sep 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This header is not necessary and is ignored by essentially all HTTP servers when provided explicitly by the user. This is because the HTTP transport layer handles adding this header automatically as needed.
Some variations of HTTP transport (like HTTP/2, which is enabled by default in Deno, Netlify, and CFW) have no notion of
Transfer-Encoding: chunked, because all responses are streamed.Changes
Transfer-Encoding: chunkedheader.Testing
If all existing streaming related tests pass, this should be considered working as I am arguing that the header is superfluous to the function of Astro.
Docs
This does not affect users in any way.