Fix: correctly transform import.meta.env.* in MDX
#4858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jackie Macharia <jackiewmacharia>
🦋 Changeset detectedLatest commit: 454f5c4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
|
clever solution 👍 |
matthewp
approved these changes
Sep 23, 2022
delucis
approved these changes
Sep 23, 2022
|
Bumping back to draft. Breaking existing export const canonical = import.meta.env.SITE + '/path' |
bholmesdev
changed the title
import.meta.env.* in MDXimport.meta.env.* in MDX
bholmesdev
commented
Sep 26, 2022
Comment on lines
+18
to
+43
| export function recmaInjectImportMetaEnvPlugin({ | ||
| importMetaEnv, | ||
| }: { | ||
| importMetaEnv: Record<string, any>; | ||
| }) { | ||
| return (tree: any) => { | ||
| estreeVisit(tree, (node) => { | ||
| if (node.type === 'MemberExpression') { | ||
| // attempt to get "import.meta.env" variable name | ||
| const envVarName = getImportMetaEnvVariableName(node as MemberExpression); | ||
| if (typeof envVarName === 'string') { | ||
| // clear object keys to replace with envVarLiteral | ||
| for (const key in node) { | ||
| delete (node as any)[key]; | ||
| } | ||
| const envVarLiteral: Literal = { | ||
| type: 'Literal', | ||
| value: importMetaEnv[envVarName], | ||
| raw: JSON.stringify(importMetaEnv[envVarName]), | ||
| }; | ||
| Object.assign(node, envVarLiteral); | ||
| } | ||
| } | ||
| }); | ||
| }; | ||
| } |
There was a problem hiding this comment.
I renamed data-astro-utils.ts to plugins.ts, so you can safely ignore the rest of the file! This function and that new getImportMetaEnvVariableName helper is the new part.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
import.meta.envin MDX plain text and frontmatter.import.meta.envin{JSX expressions}, variableexports, and HTML attributes.Testing
Test
import.meta.env.*processed in expressions only, and not transformed in plain text.Docs
N/A