fix object styles not escaped

[Calvin-LL]

Changes

Before this PR:

<div
  style={{
    backgroundImage: `url("test.png")`,
  }}
>
</div>

would be rendered as

<div
  style="background-image: url("test.png")"
>
</div>

which is invalid HTML, since the quotes in url are not escaped.

After the fix in this PR, the output is:

<div
  style="background-image: url(&#34;test.png&#34;)"
>
</div>

Also found a bug where shouldEscape isn't passed down to toAttributeString and I fixed it.

Testing

Added astro-object-style test

Docs

Minor fix

[changeset-bot]

🦋 Changeset detected

Latest commit: 882c4c8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[matthewp]

Looks great, would you mind adding a test? See packages/astro/test/fixture for examples of what our tests look like.

Also a changeset is needed:

pnpm changeset

[Calvin-LL]

Looks great, would you mind adding a test? See packages/astro/test/fixture for examples of what our tests look like.

Also a changeset is needed:

pnpm changeset

Thanks! I've added tests and ran changeset.

Update: just rebased on to the lastest HEAD on main, looks like the HEAD itself isn't passing checks either, will rebase again once fixed

[matthewp]

@Calvin-LL this is just a flakey test. Will rerun and it will likely pass. Thank you!