Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure head content rendered once with lazy layouts #4892

Merged
merged 2 commits into from Sep 28, 2022
Merged

Ensure head content rendered once with lazy layouts #4892

merged 2 commits into from Sep 28, 2022

Conversation

matthewp
Copy link
Contributor

Changes

  • When there is a lazy layout it creates a split point and a new chunk. The chunk imports from the main entrypoint to render the head.
  • This resulted in 2 instances of the weakmap :D, which meant that we falsely would render the head contents twice.
  • The fix is to remove the global weakmap and instead store this state on result._metadata, which is the same instance throughout.
  • Closes Stylesheet is duplicated on the Index page #4757

Testing

  • Test added

Docs

N/A, bug fix

@matthewp matthewp requested a review from a team as a code owner September 27, 2022 17:46
@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2022 •
edited

🦋 Changeset detected

Latest commit: 7db78a7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 27, 2022
@matthewp matthewp mentioned this pull request Sep 27, 2022
Closed
1 task
delucis
delucis approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs check: 👍

@matthewp matthewp merged commit ff7ba0e into main Sep 28, 2022
@matthewp matthewp deleted the mdx-double-head branch September 28, 2022 14:55
@astrobot-houston astrobot-houston mentioned this pull request Sep 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stylesheet is duplicated on the Index page
3 participants
@matthewp @delucis @bluwy