Move module declarations for Markdown and MDX so they're available everywhere #4928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hey're globally available
github-actions
bot
added
the
pkg: astro
🦋 Changeset detectedLatest commit: 934ad46 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I don't really get why the build is failing 🤔 |
bluwy
approved these changes
Sep 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
It turns out that importing Markdown and MDX files works outside of Astro files, so the module declaration needs to be in
client-base.d.tsand notenv.d.ts. The latter being only things available in Astro filesTesting
Tested manually. Stackblitz showing the behaviour working: https://stackblitz.com/edit/github-skrkkd?file=src%2Fscript.ts,src%2Fpages%2Findex.astro&on=stackblitz
Docs
N/A