Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates astro add to ignore optional peer dependencies #5192

Merged
merged 2 commits into from Oct 25, 2022

Conversation

tony-sull
Copy link
Contributor

Changes

Closes #5191

astro add will automatically install peer dependencies for the integration being installed. This updates that check to ignore peer dependencies marked as optional, ex: sharp is optional for @astrojs/image

Testing

Tested manually with astro add image

Before
Screen Shot 2022-10-25 at 2 27 20 PM

After
Screen Shot 2022-10-25 at 2 27 52 PM

Docs

Bug fix only, no docs update

@changeset-bot
Copy link

changeset-bot bot commented Oct 25, 2022

🦋 Changeset detected

Latest commit: 423fde1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 25, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tony-sull tony-sull merged commit 8728ee0 into main Oct 25, 2022
@tony-sull tony-sull deleted the fix/add-optional-peers branch October 25, 2022 19:57
@astrobot-houston astrobot-houston mentioned this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

astro add image installs peer dependencies marked as optional
2 participants