feat(create-astro): add --fancy flag #5226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6bf8485 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: create-astro
sarah11918
approved these changes
Oct 28, 2022
delucis
reviewed
Oct 28, 2022
| @@ -42,6 +42,7 @@ May be provided in place of prompts | |||
| |:-------------|:----------------------------------------------------| | |||
| | `--template` | Specify the template name ([list][examples]) | | |||
| | `--commit` | Specify a specific Git commit or branch to use from this repo (by default, `main` branch of this repo will be used) | | |||
| | `--fancy` | For Windows users, `--fancy` will enable full unicode support | | |||
There was a problem hiding this comment.
Did we have a --help flag that would print this stuff in the CLI in a previous version? Out of scope for this PR, but could be helpful to add in the future.
Docs here look good though! Even if I guess this README doesn’t get a lot of eyes.
There was a problem hiding this comment.
I don't think we do have a --help flag, would be nice to follow-up with!
matthewp
approved these changes
Oct 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
--fancyflag for Windows users that want full Unicode supportTesting
Tested manually
Docs
Updated the README. Houston is mostly undocumented right now!