Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(create-astro): improve error messages when create-astro fails #5240

Merged
merged 1 commit into from
Oct 28, 2022
Merged

fix(create-astro): improve error messages when create-astro fails #5240

merged 1 commit into from
Oct 28, 2022

Conversation

natemoo-re
Copy link
Member

Changes

  • There were two cases where create-astro would silently process.exit(1).
  • I think this might be making create-astro does not work #5227 worse than it seems.
  • This PR makes these exits log something so it's easier to debug.

Testing

Manually confirmed

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2022

🦋 Changeset detected

Latest commit: 360faa5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: create-astro Related to the `create-astro` package (scope) label Oct 28, 2022
@natemoo-re natemoo-re mentioned this pull request Oct 28, 2022
Closed
1 task
matthewp
matthewp approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@natemoo-re natemoo-re merged commit d9be7e3 into main Oct 28, 2022
@natemoo-re natemoo-re deleted the fix/create-astro branch October 28, 2022 19:05
@astrobot-houston astrobot-houston mentioned this pull request Oct 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp approved these changes

Assignees
No one assigned
Labels
pkg: create-astro Related to the `create-astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@natemoo-re @matthewp