Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node: better serverEntrypoint error #5560

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Conversation

natemoo-re
Copy link
Member

Changes

  • We were accidentally logging ${fileURLToPath} instead of ${fileURLToPath(serverEntrypoint)}

Testing

Tested manually

Docs

N/A, bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2022

🦋 Changeset detected

Latest commit: c2f4825

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Dec 8, 2022
@natemoo-re natemoo-re merged commit 281ea9f into main Dec 8, 2022
@natemoo-re natemoo-re deleted the fix/node-entrypoint-error branch December 8, 2022 20:54
@astrobot-houston astrobot-houston mentioned this pull request Dec 8, 2022
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first I didn't see the (entry)point, but I get it now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants