Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create-astro on Windows #5616

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Fix create-astro on Windows #5616

merged 2 commits into from
Dec 16, 2022

Conversation

natemoo-re
Copy link
Member

Changes

  • Skips Houston animations on Windows, which seem to be breaking the prompt
  • Linked to create-astro does not work #5227 but I'm not confident it fixes all Windows issues

Testing

Tested manually

Docs

N/A, bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Dec 16, 2022

🦋 Changeset detected

Latest commit: 75b9e53

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: create-astro Related to the `create-astro` package (scope) label Dec 16, 2022
@natemoo-re
Copy link
Member Author

!preview fixwin

@github-actions
Copy link
Contributor

 > root@0.0.0 release /home/runner/work/astro/astro > pnpm run build && changeset publish "--tag" "next--fixwin" > root@0.0.0 build /home/runner/work/astro/astro > turbo run build --output-logs=new-only --no-deps --filter=astro --filter=create-astro --filter="@astrojs/*" �[2m• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/deno, @astrojs/image, @astrojs/lit, @astrojs/markdown-component, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prefetch, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/turbolinks, @astrojs/vercel, @astrojs/vue, @astrojs/webapi, astro, create-astro�[0m �[2m• Running�[0m �[2m�[1mbuild�[0m�[0m �[2min 27 packages�[0m �[2m• Remote computation caching enabled (experimental)�[0m �[35m@astrojs/webapi:build: �[0mcache hit, suppressing output �[2mf37b3a27f8f37505�[0m �[34m@astrojs/prism:build: �[0mcache hit, suppressing output �[2m4c9d1606c6184f2c�[0m �[36m@astrojs/telemetry:build: �[0mcache hit, suppressing output �[2m3bae4321514e3d88�[0m �[35m@astrojs/markdown-remark:build: �[0mcache hit, suppressing output �[2m5323cfed8c64c18f�[0m �[33mcreate-astro:build: �[0mcache miss, executing �[2mcb3cf960d53190fe�[0m �[32mastro:build: �[0mcache miss, executing �[2m149180fb058253f3�[0m �[33mcreate-astro:build: �[0m �[33mcreate-astro:build: �[0m> create-astro@0.0.0-fixwin-20221216184820 build /home/runner/work/astro/astro/packages/create-astro �[33mcreate-astro:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33mcreate-astro:build: �[0m �[32mastro:build: �[0m �[32mastro:build: �[0m> astro@0.0.0-fixwin-20221216184820 build /home/runner/work/astro/astro/packages/astro �[32mastro:build: �[0m> pnpm run prebuild && astro-scripts build "src/**/*.ts" && tsc �[32mastro:build: �[0m �[32mastro:build: �[0m �[32mastro:build: �[0m> astro@0.0.0-fixwin-20221216184820 prebuild /home/runner/work/astro/astro/packages/astro �[32mastro:build: �[0m> astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts" �[32mastro:build: �[0m �[33m@astrojs/lit:build: �[0mcache miss, executing �[2m90ae3469719420a7�[0m �[36m@astrojs/mdx:build: �[0mcache miss, executing �[2m9bb5097017463750�[0m �[36m@astrojs/react:build: �[0mcache miss, executing �[2mc2c87a36280de547�[0m �[35m@astrojs/svelte:build: �[0mcache miss, executing �[2m2f5fb5afbc3adfe4�[0m �[34m@astrojs/turbolinks:build: �[0mcache miss, executing �[2m085faa86576e8bcb�[0m �[32m@astrojs/partytown:build: �[0mcache miss, executing �[2m077787c1a17fd031�[0m �[32m@astrojs/node:build: �[0mcache miss, executing �[2mccb6f83bb32c5061�[0m �[34m@astrojs/alpinejs:build: �[0mcache miss, executing �[2md897a66554700c8a�[0m �[35m@astrojs/sitemap:build: �[0mcache miss, executing �[2m3220efd1cbcb9b82�[0m �[33m@astrojs/deno:build: �[0mcache miss, executing �[2mea7f3dc7ef1b945b�[0m �[33m@astrojs/lit:build: �[0m �[33m@astrojs/lit:build: �[0m> @astrojs/lit@1.0.1 build /home/runner/work/astro/astro/packages/integrations/lit �[33m@astrojs/lit:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/lit:build: �[0m �[36m@astrojs/mdx:build: �[0m �[36m@astrojs/mdx:build: �[0m> @astrojs/mdx@0.12.2 build /home/runner/work/astro/astro/packages/integrations/mdx �[36m@astrojs/mdx:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/mdx:build: �[0m �[36m@astrojs/react:build: �[0m �[36m@astrojs/react:build: �[0m> @astrojs/react@1.2.2 build /home/runner/work/astro/astro/packages/integrations/react �[36m@astrojs/react:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/react:build: �[0m �[32m@astrojs/partytown:build: �[0m �[32m@astrojs/partytown:build: �[0m> @astrojs/partytown@1.0.2 build /home/runner/work/astro/astro/packages/integrations/partytown �[32m@astrojs/partytown:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/partytown:build: �[0m �[34m@astrojs/turbolinks:build: �[0m �[34m@astrojs/turbolinks:build: �[0m> @astrojs/turbolinks@0.1.4 build /home/runner/work/astro/astro/packages/integrations/turbolinks �[34m@astrojs/turbolinks:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/turbolinks:build: �[0m �[35m@astrojs/svelte:build: �[0m �[35m@astrojs/svelte:build: �[0m> @astrojs/svelte@1.0.2 build /home/runner/work/astro/astro/packages/integrations/svelte �[35m@astrojs/svelte:build: �[0m> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc �[35m@astrojs/svelte:build: �[0m �[34m@astrojs/alpinejs:build: �[0m �[34m@astrojs/alpinejs:build: �[0m> @astrojs/alpinejs@0.1.2 build /home/runner/work/astro/astro/packages/integrations/alpinejs �[34m@astrojs/alpinejs:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/alpinejs:build: �[0m �[35m@astrojs/sitemap:build: �[0m �[35m@astrojs/sitemap:build: �[0m> @astrojs/sitemap@1.0.0 build /home/runner/work/astro/astro/packages/integrations/sitemap �[35m@astrojs/sitemap:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/sitemap:build: �[0m �[32m@astrojs/node:build: �[0m �[32m@astrojs/node:build: �[0m> @astrojs/node@0.0.0-fixwin-20221216184820 build /home/runner/work/astro/astro/packages/integrations/node �[32m@astrojs/node:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/node:build: �[0m �[33m@astrojs/deno:build: �[0m �[33m@astrojs/deno:build: �[0m> @astrojs/deno@0.0.0-fixwin-20221216184820 build /home/runner/work/astro/astro/packages/integrations/deno �[33m@astrojs/deno:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/deno:build: �[0m �[33m@astrojs/prefetch:build: �[0mcache miss, executing �[2m25845cfb12ec44cd�[0m �[34m@astrojs/rss:build: �[0mcache miss, executing �[2m95118143cf11514d�[0m �[36m@astrojs/vue:build: �[0mcache miss, executing �[2m26110b897da72933�[0m �[32m@astrojs/cloudflare:build: �[0mcache miss, executing �[2m1d523033c7252800�[0m �[35m@astrojs/vercel:build: �[0mcache miss, executing �[2mae54c486ae9fe092�[0m �[33m@astrojs/solid-js:build: �[0mcache miss, executing �[2mc1caa7e8ee24cfcd�[0m �[33m@astrojs/prefetch:build: �[0m �[33m@astrojs/prefetch:build: �[0m> @astrojs/prefetch@0.1.1 build /home/runner/work/astro/astro/packages/integrations/prefetch �[33m@astrojs/prefetch:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/prefetch:build: �[0m �[34m@astrojs/rss:build: �[0m �[34m@astrojs/rss:build: �[0m> @astrojs/rss@1.2.1 build /home/runner/work/astro/astro/packages/astro-rss �[34m@astrojs/rss:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/rss:build: �[0m �[34m@astrojs/tailwind:build: �[0mcache miss, executing �[2mb3bcbfe0403ee6f6�[0m �[36m@astrojs/vue:build: �[0m �[36m@astrojs/vue:build: �[0m> @astrojs/vue@1.2.2 build /home/runner/work/astro/astro/packages/integrations/vue �[36m@astrojs/vue:build: �[0m> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc �[36m@astrojs/vue:build: �[0m �[32m@astrojs/cloudflare:build: �[0m �[32m@astrojs/cloudflare:build: �[0m> @astrojs/cloudflare@0.0.0-fixwin-20221216184820 build /home/runner/work/astro/astro/packages/integrations/cloudflare �[32m@astrojs/cloudflare:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/cloudflare:build: �[0m �[36m@astrojs/preact:build: �[0mcache miss, executing �[2m5bd7b212a4e1ab32�[0m �[35m@astrojs/vercel:build: �[0m �[35m@astrojs/vercel:build: �[0m> @astrojs/vercel@2.3.6 build /home/runner/work/astro/astro/packages/integrations/vercel �[35m@astrojs/vercel:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/vercel:build: �[0m �[33m@astrojs/solid-js:build: �[0m �[33m@astrojs/solid-js:build: �[0m> @astrojs/solid-js@1.2.3 build /home/runner/work/astro/astro/packages/integrations/solid �[33m@astrojs/solid-js:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/solid-js:build: �[0m �[32m@astrojs/netlify:build: �[0mcache miss, executing �[2m094d5c27f721eec8�[0m �[34m@astrojs/tailwind:build: �[0m �[34m@astrojs/tailwind:build: �[0m> @astrojs/tailwind@2.1.3 build /home/runner/work/astro/astro/packages/integrations/tailwind �[34m@astrojs/tailwind:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/tailwind:build: �[0m �[36m@astrojs/preact:build: �[0m �[36m@astrojs/preact:build: �[0m> @astrojs/preact@1.2.0 build /home/runner/work/astro/astro/packages/integrations/preact �[36m@astrojs/preact:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/preact:build: �[0m �[32m@astrojs/netlify:build: �[0m �[32m@astrojs/netlify:build: �[0m> @astrojs/netlify@0.0.0-fixwin-20221216184820 build /home/runner/work/astro/astro/packages/integrations/netlify �[32m@astrojs/netlify:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/netlify:build: �[0m �[33m@astrojs/image:build: �[0mcache miss, executing �[2m03a922caba1503f7�[0m �[33m@astrojs/image:build: �[0m �[33m@astrojs/image:build: �[0m> @astrojs/image@0.12.1 build /home/runner/work/astro/astro/packages/integrations/image �[33m@astrojs/image:build: �[0m> astro-scripts build "src/**/*.ts" && tsc && pnpm run postbuild �[33m@astrojs/image:build: �[0m �[33m@astrojs/image:build: �[0m �[33m@astrojs/image:build: �[0m> @astrojs/image@0.12.1 postbuild /home/runner/work/astro/astro/packages/integrations/image �[33m@astrojs/image:build: �[0m> astro-scripts copy "src/**/*.wasm" �[33m@astrojs/image:build: �[0m Tasks: 26 successful, 26 total Cached: 4 cached, 26 total Time: 1m2.31s 🦋 �[33mwarn�[39m �[31m===============================IMPORTANT!===============================�[39m 🦋 �[33mwarn�[39m Packages will be released under the next--fixwin tag 🦋 �[33mwarn�[39m �[31m----------------------------------------------------------------------�[39m 🦋 �[36minfo�[39m npm info astro 🦋 �[36minfo�[39m npm info @astrojs/prism 🦋 �[36minfo�[39m npm info @astrojs/rss 🦋 �[36minfo�[39m npm info create-astro 🦋 �[36minfo�[39m npm info @astrojs/alpinejs 🦋 �[36minfo�[39m npm info @astrojs/cloudflare 🦋 �[36minfo�[39m npm info @astrojs/deno 🦋 �[36minfo�[39m npm info @astrojs/image 🦋 �[36minfo�[39m npm info @astrojs/lit 🦋 �[36minfo�[39m npm info @astrojs/mdx 🦋 �[36minfo�[39m npm info @astrojs/netlify 🦋 �[36minfo�[39m npm info @astrojs/node 🦋 �[36minfo�[39m npm info @astrojs/partytown 🦋 �[36minfo�[39m npm info @astrojs/preact 🦋 �[36minfo�[39m npm info @astrojs/prefetch 🦋 �[36minfo�[39m npm info @astrojs/react 🦋 �[36minfo�[39m npm info @astrojs/sitemap 🦋 �[36minfo�[39m npm info @astrojs/solid-js 🦋 �[36minfo�[39m npm info @astrojs/svelte 🦋 �[36minfo�[39m npm info @astrojs/tailwind 🦋 �[36minfo�[39m npm info @astrojs/turbolinks 🦋 �[36minfo�[39m npm info @astrojs/vercel 🦋 �[36minfo�[39m npm info @astrojs/vue 🦋 �[36minfo�[39m npm info @astrojs/markdown-component 🦋 �[36minfo�[39m npm info @astrojs/markdown-remark 🦋 �[36minfo�[39m npm info @astrojs/telemetry 🦋 �[36minfo�[39m npm info @astrojs/webapi 🦋 �[36minfo�[39m astro is being published because our local version (0.0.0-fixwin-20221216184820) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/prism is not being published because version 1.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/rss is not being published because version 1.2.1 is already published on npm 🦋 �[36minfo�[39m create-astro is being published because our local version (0.0.0-fixwin-20221216184820) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/alpinejs is not being published because version 0.1.2 is already published on npm 🦋 �[36minfo�[39m @astrojs/cloudflare is being published because our local version (0.0.0-fixwin-20221216184820) has not been published on npm 🦋 �[36minfo�[39m @astrojs/deno is being published because our local version (0.0.0-fixwin-20221216184820) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/image is not being published because version 0.12.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/lit is not being published because version 1.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/mdx is not being published because version 0.12.2 is already published on npm 🦋 �[36minfo�[39m @astrojs/netlify is being published because our local version (0.0.0-fixwin-20221216184820) has not been published on npm 🦋 �[36minfo�[39m @astrojs/node is being published because our local version (0.0.0-fixwin-20221216184820) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/partytown is not being published because version 1.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/preact is not being published because version 1.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/prefetch is not being published because version 0.1.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/react is not being published because version 1.2.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/sitemap is not being published because version 1.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/solid-js is not being published because version 1.2.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/svelte is not being published because version 1.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/tailwind is not being published because version 2.1.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/turbolinks is not being published because version 0.1.4 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vercel is not being published because version 2.3.6 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vue is not being published because version 1.2.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdown-component is not being published because version 1.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdown-remark is not being published because version 1.1.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/telemetry is not being published because version 1.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/webapi is not being published because version 1.1.1 is already published on npm 🦋 �[36minfo�[39m Publishing �[36m"astro"�[39m at �[32m"0.0.0-fixwin-20221216184820"�[39m 🦋 �[36minfo�[39m Publishing �[36m"create-astro"�[39m at �[32m"0.0.0-fixwin-20221216184820"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/cloudflare"�[39m at �[32m"0.0.0-fixwin-20221216184820"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/deno"�[39m at �[32m"0.0.0-fixwin-20221216184820"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/netlify"�[39m at �[32m"0.0.0-fixwin-20221216184820"�[39m 🦋 �[36minfo�[39m Publishing �[36m"@astrojs/node"�[39m at �[32m"0.0.0-fixwin-20221216184820"�[39m 🦋 �[32msuccess�[39m packages published successfully: 🦋 astro@0.0.0-fixwin-20221216184820 🦋 create-astro@0.0.0-fixwin-20221216184820 🦋 @astrojs/cloudflare@0.0.0-fixwin-20221216184820 🦋 @astrojs/deno@0.0.0-fixwin-20221216184820 🦋 @astrojs/netlify@0.0.0-fixwin-20221216184820 🦋 @astrojs/node@0.0.0-fixwin-20221216184820 🦋 Creating git tags... 🦋 New tag: astro@0.0.0-fixwin-20221216184820 🦋 New tag: create-astro@0.0.0-fixwin-20221216184820 🦋 New tag: @astrojs/cloudflare@0.0.0-fixwin-20221216184820 🦋 New tag: @astrojs/deno@0.0.0-fixwin-20221216184820 🦋 New tag: @astrojs/netlify@0.0.0-fixwin-20221216184820 🦋 New tag: @astrojs/node@0.0.0-fixwin-20221216184820

@natemoo-re
Copy link
Member Author

Confirmed via Windows users on Discord that this fixed it!

Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure windows peeps will appreciate this a hous-ton

@@ -30,6 +31,8 @@ import { TEMPLATES } from './templates.js';
// fixes the issue so that create-astro now works on all npm version.
const cleanArgv = process.argv.filter((arg) => arg !== '--');
const args = yargs(cleanArgv, { boolean: ['fancy'] });
// Always skip Houston on Windows (for now)
if (platform() === 'win32') args.skipHouston = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sad houston beep boops

@matthewp matthewp merged commit 61302ab into main Dec 16, 2022
@matthewp matthewp deleted the fix/windows-create-astro branch December 16, 2022 20:48
@astrobot-houston astrobot-houston mentioned this pull request Dec 16, 2022
@natemoo-re natemoo-re mentioned this pull request Jan 4, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: create-astro Related to the `create-astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants