[content collections] Handle file name spaces and capitalization

[bholmesdev]

Changes

• Resolves Content Collections break when file names have spaces #5640
• Replace incorrect new URL usage with a safer split('?') pattern. This prevents spaces from being resolved to %20.
• Introduce github-slugger to calculate content slugs. Previously, we simply chopped the extension from the file name. Slugifying each segment should handle capitalization and spaces for use in getStaticPaths.
  • Before: english translations/Using Mdx.mdx -> english translations/Using Mdx
  • After: english translations/Using Mdx.mdx -> english-translations/using-mdx
• chore: bump to github-slugger 2.0. This migrates from CommonJS to ESM but does not introduce API changes (see release notes).

Testing

• Add file name with spaces to content-collections fixture
• Unit test getEntryInfo()

Docs

withastro/docs#2245

[changeset-bot]

🦋 Changeset detected

Latest commit: 0fe19b5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

[github-actions]

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

[github-actions]

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

[github-actions]

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

[github-actions]

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

[Princesseuh]

Looks good to me! Appreciate the tests, awesome work

[github-actions]

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

[matthewp]

code looks good, just need to resolve merge conflicts

[github-actions]

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

[surjithctly]

Does this PR closes issue with spaces in a parent folder name? eg: ./My Works/astro/project

The error was:

[plugin:astro-delayed-asset-plugin] ENOENT: no such file or directory, open 
'/Users/My%20Works/astro/project/src/content/blog/article-name.md'

[bholmesdev]

@surjithctly Yes it should! Probably worth an extra unit test for sanity though 👍

[github-actions]

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

ready to merge

[surjithctly]

Sadly, this doesn't fix the space issue in a parent folder. 👎

I think there should be a unit-test as you said to make sure it doesn't have a regression.

[bholmesdev]

@surjithctly Well, you're right there 😓 I made the compromise yesterday of merging this fix as-is to ship our minor release, since this PR does solve other existing problems with content collections. Was worth delaying our release for further testing in hindsight.

It also looks like an issue outside of content collections after seeing #5598. We can follow-up there as we investigate a fix!