Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy.astroFlavoredMarkdown #5771

Merged
merged 3 commits into from
Jan 5, 2023
Merged

Remove legacy.astroFlavoredMarkdown #5771

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6c0848
Remove legacy.astroFlavoredMarkdown
matthewp Jan 5, 2023
d217cdd
update vue mdx test
matthewp Jan 5, 2023
a920503
Add a changeset
matthewp Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions packages/astro/e2e/fixtures/preact-compat-component/astro.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,5 @@ import preact from '@astrojs/preact';

// https://astro.build/config
export default defineConfig({
legacy: {
astroFlavoredMarkdown: true,
},
integrations: [preact({ compat: true })],
});
32 changes: 0 additions & 32 deletions packages/astro/e2e/fixtures/preact-compat-component/src/pages/markdown.md
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions packages/astro/e2e/fixtures/preact-component/astro.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,5 @@ import mdx from '@astrojs/mdx';

// https://astro.build/config
export default defineConfig({
legacy: {
astroFlavoredMarkdown: true,
},
integrations: [preact(), mdx()],
});
32 changes: 0 additions & 32 deletions packages/astro/e2e/fixtures/preact-component/src/pages/markdown.md
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions packages/astro/e2e/fixtures/react-component/astro.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,5 @@ import mdx from '@astrojs/mdx';

// https://astro.build/config
export default defineConfig({
legacy: {
astroFlavoredMarkdown: true,
},
integrations: [react(), mdx()],
});
32 changes: 0 additions & 32 deletions packages/astro/e2e/fixtures/react-component/src/pages/markdown.md
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions packages/astro/e2e/fixtures/solid-component/astro.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,5 @@ import solid from '@astrojs/solid-js';

// https://astro.build/config
export default defineConfig({
legacy: {
astroFlavoredMarkdown: true,
},
integrations: [solid(), mdx()],
});
32 changes: 0 additions & 32 deletions packages/astro/e2e/fixtures/solid-component/src/pages/markdown.md
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions packages/astro/e2e/fixtures/svelte-component/astro.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,5 @@ import mdx from '@astrojs/mdx';

// https://astro.build/config
export default defineConfig({
legacy: {
astroFlavoredMarkdown: true,
},
integrations: [svelte(), mdx()],
});
32 changes: 0 additions & 32 deletions packages/astro/e2e/fixtures/svelte-component/src/pages/markdown.md
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions packages/astro/e2e/fixtures/vue-component/astro.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ import mdx from '@astrojs/mdx';

// https://astro.build/config
export default defineConfig({
legacy: {
astroFlavoredMarkdown: true,
},
integrations: [
mdx(),
vue({
Expand Down
32 changes: 0 additions & 32 deletions packages/astro/e2e/fixtures/vue-component/src/pages/markdown.md
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions packages/astro/e2e/preact-compat-component.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,3 @@ test.describe('preact/compat components in Astro files', () => {
pageSourceFilePath: './src/pages/index.astro',
});
});

test.describe('preact/compat components in Markdown files', () => {
createTests({
...config,
pageUrl: '/markdown/',
pageSourceFilePath: './src/pages/markdown.md',
});
});
8 changes: 0 additions & 8 deletions packages/astro/e2e/preact-component.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,6 @@ test.describe('Preact components in Astro files', () => {
});
});

test.describe('Preact components in Markdown files', () => {
createTests({
...config,
pageUrl: '/markdown/',
pageSourceFilePath: './src/pages/markdown.md',
});
});

test.describe('Preact components in MDX files', () => {
createTests({
...config,
Expand Down
8 changes: 0 additions & 8 deletions packages/astro/e2e/react-component.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,6 @@ test.describe('React components in Astro files', () => {
});
});

test.describe('React components in Markdown files', () => {
createTests({
...config,
pageUrl: '/markdown/',
pageSourceFilePath: './src/pages/markdown.md',
});
});

test.describe('React components in MDX files', () => {
createTests({
...config,
Expand Down
8 changes: 0 additions & 8 deletions packages/astro/e2e/solid-component.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,6 @@ test.describe('Solid components in Astro files', () => {
});
});

test.describe('Solid components in Markdown files', () => {
createTests({
...config,
pageUrl: '/markdown/',
pageSourceFilePath: './src/pages/markdown.md',
});
});

test.describe('Solid components in MDX files', () => {
createTests({
...config,
Expand Down
8 changes: 0 additions & 8 deletions packages/astro/e2e/svelte-component.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,6 @@ test.describe('Svelte components in Astro files', () => {
});
});

test.describe('Svelte components in Markdown files', () => {
createTests({
...config,
pageUrl: '/markdown/',
pageSourceFilePath: './src/pages/markdown.md',
});
});

test.describe('Svelte components in MDX files', () => {
createTests({
...config,
Expand Down
8 changes: 0 additions & 8 deletions packages/astro/e2e/vue-component.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,6 @@ test.describe('Vue components in Astro files', () => {
});
});

test.describe('Vue components in Markdown files', () => {
createTests({
...config,
pageUrl: '/markdown/',
pageSourceFilePath: './src/pages/markdown.md',
});
});

test.describe('Vue components in MDX files', () => {
createTests({
...config,
Expand Down
25 changes: 1 addition & 24 deletions packages/astro/src/@types/astro.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,30 +870,7 @@ export interface AstroUserConfig {
* These flags allow you to opt in to some deprecated or otherwise outdated behavior of Astro
* in the latest version, so that you can continue to upgrade and take advantage of new Astro releases.
*/
legacy?: {
/**
* @docs
* @name legacy.astroFlavoredMarkdown
* @type {boolean}
* @default `false`
* @version 1.0.0-rc.1
* @description
* Enable Astro's pre-v1.0 support for components and JSX expressions in `.md` (and alternative extensions for markdown files like ".markdown") Markdown files.
* In Astro `1.0.0-rc`, this original behavior was removed as the default, in favor of our new [MDX integration](https://docs.astro.build/en/guides/integrations-guide/mdx/).
*
* To enable this behavior, set `legacy.astroFlavoredMarkdown` to `true` in your [`astro.config.mjs` configuration file](https://docs.astro.build/en/guides/configuring-astro/#the-astro-config-file).
*
* ```js
* {
* legacy: {
* // Example: Add support for legacy Markdown features
* astroFlavoredMarkdown: true,
* },
* }
* ```
*/
astroFlavoredMarkdown?: boolean;
};
legacy?: object;

/**
* @docs
Expand Down
1 change: 0 additions & 1 deletion packages/astro/src/core/build/generate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,6 @@ async function generatePath(
logging,
markdown: {
...settings.config.markdown,
isAstroFlavoredMd: settings.config.legacy.astroFlavoredMarkdown,
isExperimentalContentCollections: settings.config.experimental.contentCollections,
contentDir: getContentPaths(settings.config).contentDir,
},
Expand Down
1 change: 0 additions & 1 deletion packages/astro/src/core/build/vite-plugin-ssr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,6 @@ function buildManifest(
base: settings.config.base,
markdown: {
...settings.config.markdown,
isAstroFlavoredMd: settings.config.legacy.astroFlavoredMarkdown,
isExperimentalContentCollections: settings.config.experimental.contentCollections,
contentDir: getContentPaths(settings.config).contentDir,
},
Expand Down
Loading