Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support envPrefix in Astro config #5852

Merged
merged 7 commits into from
Jan 13, 2023
Merged

Support envPrefix in Astro config #5852

merged 7 commits into from
Jan 13, 2023

Conversation

rishi-raj-jain
Copy link
Contributor

@rishi-raj-jain rishi-raj-jain commented Jan 13, 2023 •
edited
Loading

Fixes #5827

Changes

  • What does this change?
  • Be short and concise. Bullet points can help!
  • Before/after screenshots can help as well.
  • Don't forget a changeset! pnpm exec changeset

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: f2b4b53

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 13, 2023
natemoo-re
natemoo-re requested changes Jan 13, 2023
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can fix this without adding a new top-level envPrefix option. We try to rely on the vite config option for things that are already supported by Vite.

packages/astro/src/core/build/static-build.ts Outdated Show resolved Hide resolved
packages/astro/src/core/build/static-build.ts Outdated Show resolved Hide resolved
packages/astro/src/core/config/schema.ts Outdated Show resolved Hide resolved
packages/astro/src/core/config/schema.ts Outdated Show resolved Hide resolved
packages/astro/src/core/create-vite.ts Outdated Show resolved Hide resolved
Rishi Raj Jain and others added 5 commits January 13, 2023 23:26
@natemoo-re
Update packages/astro/src/core/config/schema.ts
3128564 
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
@natemoo-re
Update packages/astro/src/core/build/static-build.ts
f9e26db 
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
@natemoo-re
Update packages/astro/src/core/build/static-build.ts
3cbfa56 
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
@natemoo-re
Update packages/astro/src/core/config/schema.ts
85a2e25 
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
@natemoo-re
Update packages/astro/src/core/create-vite.ts
30ea9cc 
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
@natemoo-re natemoo-re self-requested a review January 13, 2023 18:54
natemoo-re
natemoo-re approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for the fix!

@natemoo-re natemoo-re merged commit 3a00ecb into withastro:main Jan 13, 2023
@astrobot-houston astrobot-houston mentioned this pull request Jan 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Astro ignores vite.envPrefix only during production build
2 participants
@rishi-raj-jain @natemoo-re