Fix image integration not working on Node 18+ #5871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4c54eeb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
bluwy
approved these changes
Jan 16, 2023
There was a problem hiding this comment.
Looks like it needs a changeset, otherwise this looks good!
I was curious if this would drop support for worker or Deno environments, but it looks like these files are meant to run in Node.js (especially given the file names include _node_), so I think we're safe here too.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When we removed support for Node 14, we migrated to undici. This caused an issue with our image integration because
squooshuses a fetch to load a local.wasmfile, which is not supported by undici (and is unlikely to be for some time).This PR removes the code for that and instead opt to use the fallback only. This is also what Next.js does, so it should be okay!
Fix #5866
Fix #5714
Fix #5473
Fix #4980
Testing
Tests still pass + manual tests
Docs
N/A