Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLI node version check #5905

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Fix CLI node version check #5905

merged 2 commits into from
Jan 20, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jan 19, 2023 •
edited

Changes

Check nodejs version support via semver only, rather than whether it supports ESM, since we're relying on node 16 features now.

NOTE: The supports-esm dep can be removed, but I might do that as a separate PR as the lockfile needs to be fixed by the next beta release first.

Testing

Tested manually, here are the logs for lower node versions:

Node.js v10.24.1 is not supported by Astro!
Please upgrade Node.js to a supported version: ">=16.12.0"

Node.js v12.22.12 is not supported by Astro!
Please upgrade Node.js to a supported version: ">=16.12.0"

Node.js v14.18.3 is not supported by Astro!
Please upgrade Node.js to a supported version: ">=16.12.0"

The CLI works after using a supported node version.

I also tested that ci-info is working as well.

Docs

n/a

@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2023 •
edited

🦋 Changeset detected

Latest commit: f3faedb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 19, 2023
@bluwy bluwy merged commit a8d3e79 into main Jan 20, 2023
@bluwy bluwy deleted the fix-node-check branch January 20, 2023 07:37
@astrobot-houston astrobot-houston mentioned this pull request Jan 20, 2023
Merged
matthewp pushed a commit that referenced this pull request Jan 26, 2023
@bluwy @matthewp
Fix CLI node version check (#5905)
b2ce697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bluwy @matthewp