Fix Content Collections not loading config file when there are spaces in the folder tree #5962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9b14114 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
Can you add a test? Also I think it should be done like its done here: https://github.com/withastro/astro/blob/main/packages/astro/src/core/render/dev/index.ts#L60 using |
1 task
Ah ok, testing that |
This comment was marked as outdated.
This comment was marked as outdated.
MoustaphaDev
commented
Jan 24, 2023
bholmesdev
approved these changes
Jan 24, 2023
|
The failing test is the flaky one, will restart. |
This comment was marked as outdated.
This comment was marked as outdated.
Merged
matthewp
pushed a commit
that referenced
this pull request
Jan 26, 2023
… in the folder tree (#5962) * fix * add test * use `fileURLToPath` instead * chore: changeset * remove useless config file * revert back to using `decodeURIComponent` * test: better test * re-revert back to using `fileURLToPath`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #5961
Testing
TODO
Docs
N/A, bug fix