Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve --root CLI flag on restart #6049

Merged
merged 4 commits into from Feb 9, 2023
Merged

Preserve --root CLI flag on restart #6049

merged 4 commits into from Feb 9, 2023

Conversation

natemoo-re
Copy link
Member

Changes

Testing

Tested manually since this is a hard one to automate

Docs

N/A, bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2023

🦋 Changeset detected

Latest commit: 0ad7666

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 30, 2023
@natemoo-re natemoo-re marked this pull request as draft January 30, 2023 20:45
@natemoo-re natemoo-re marked this pull request as ready for review February 6, 2023 21:50
@natemoo-re natemoo-re marked this pull request as draft February 6, 2023 21:57
@github-actions github-actions bot removed the pkg: astro Related to the core `astro` package (scope) label Feb 9, 2023
@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 9, 2023
@natemoo-re natemoo-re marked this pull request as ready for review February 9, 2023 19:25
@natemoo-re natemoo-re merged commit 8b7cb64 into main Feb 9, 2023
@natemoo-re natemoo-re deleted the fix/restart-root branch February 9, 2023 20:02
@astrobot-houston astrobot-houston mentioned this pull request Feb 9, 2023
@tschaub
Copy link

tschaub commented Feb 9, 2023

Thanks for the work on this, @natemoo-re

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The --root option is lost on configuration updates and restarts
3 participants