Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump vitefu for @astrojs/solid-js #6104

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

yasserhennawi
Copy link
Contributor

Changes

image

Testing

  • No tests needed, Vite4 is already being installed for astro V2

Docs

  • No docs needed, just a package patch bump.

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2023

🦋 Changeset detected

Latest commit: 92e8f30

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: solid Related to Solid (scope) pkg: integration Related to any renderer integration (scope) labels Feb 2, 2023
@yasserhennawi
Copy link
Contributor Author

yasserhennawi commented Feb 2, 2023

@bholmesdev this test case SSG pictures - dev failed for with Timeout exceeded,
Is this a known issue from time to time, and you need to re-run the test, or is it related to the changes somehow? 😅
image

@bluwy bluwy merged commit 8c80e78 into withastro:main Feb 2, 2023
@bluwy
Copy link
Member

bluwy commented Feb 2, 2023

Thanks for the fix! I think the test is flaky for that case. Seems unrelated to this PR.

@astrobot-houston astrobot-houston mentioned this pull request Feb 2, 2023
@yasserhennawi yasserhennawi deleted the chore/bump-vitefu branch February 2, 2023 16:08
matthewp pushed a commit that referenced this pull request Feb 3, 2023
Co-authored-by: Yasser Hennawi <yasser.hennawi@nordsec.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: solid Related to Solid (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants