Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scanning sourcemap handling #6114

Merged
merged 1 commit into from Feb 3, 2023
Merged

Fix scanning sourcemap handling #6114

merged 1 commit into from Feb 3, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Feb 3, 2023

Changes

Fix #6058

According to https://rollupjs.org/plugin-development/#transform, returning map: null means code doesn't change and preserve the current sourcemap. This PR adds the map: null as it's the case for us.

Testing

Manual testing in basics example.

Docs

n/a. bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2023

🦋 Changeset detected

Latest commit: 0a67065

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 3, 2023
@bluwy bluwy merged commit ac7fb04 into main Feb 3, 2023
@bluwy bluwy deleted the fix-scan-sourcemap branch February 3, 2023 12:47
@astrobot-houston astrobot-houston mentioned this pull request Feb 3, 2023
matthewp pushed a commit that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Astro 2.0 warning when using sourcemaps
2 participants