Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take dynamic imports into account for CSS ordering #6176

Merged
merged 3 commits into from Feb 8, 2023
Merged

Take dynamic imports into account for CSS ordering #6176

merged 3 commits into from Feb 8, 2023

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Feb 8, 2023

Changes

Testing

  • New test case added

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2023

⚠️ No Changeset found

Latest commit: b95a02c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 8, 2023
@matthewp matthewp mentioned this pull request Feb 8, 2023
Closed
1 task
@JerryWu1234
Copy link
Contributor

thanks

natemoo-re
natemoo-re approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the good code comments! 👍🏻

@matthewp matthewp merged commit 8bbdcf1 into main Feb 8, 2023
@matthewp matthewp deleted the css-order-dynmic branch February 8, 2023 15:15
@astrobot-houston astrobot-houston mentioned this pull request Feb 8, 2023
Merged
@bluwy bluwy mentioned this pull request Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

astro with tailwind incorrect style css order in subpath
3 participants
@matthewp @JerryWu1234 @natemoo-re