Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-astro): Pin giget to 1.0.0 #6278

Merged
merged 1 commit into from
Feb 17, 2023
Merged

fix(create-astro): Pin giget to 1.0.0 #6278

merged 1 commit into from
Feb 17, 2023

Conversation

Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented Feb 17, 2023

Changes

An upstream issue in giget is causing downloadTemplate to cause a 400 when hitting GitHub. (see unjs/giget#81 ) Their own CI caught this, but they unfortunately still released the update. This PR pins the version to 1.0.0 in the meantime

Fix #6276

Testing

Tested manually

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2023

🦋 Changeset detected

Latest commit: 6d13c3d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: create-astro Related to the `create-astro` package (scope) label Feb 17, 2023
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Princesseuh Princesseuh merged commit 0f5d122 into main Feb 17, 2023
@Princesseuh Princesseuh deleted the fix/giget branch February 17, 2023 13:45
@astrobot-houston astrobot-houston mentioned this pull request Feb 17, 2023
@pi0
Copy link

pi0 commented Feb 17, 2023

Issues should be fixed in latest giget release v1.1.1 (unjs/giget#82) :)

@Princesseuh Princesseuh self-assigned this Feb 17, 2023
liruifengv pushed a commit to liruifengv/astro that referenced this pull request Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: create-astro Related to the `create-astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm create astro@latest fails with 400 Bad Request
3 participants