[Lit] render DSD attributes based on shadowRootOptions
#6351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Changes - Update `@astrojs/lit`’s `server.js` to properly render elements with `delegatesFocus: false` set in their `shadowRootOptions`. - Logic is based on `@lit-labs/ssr` [latest implementation as found here](https://github.com/lit/lit/blob/b0c3f82ef0f97326a205e77e7e1043b75a5cc53f/packages/labs/ssr/src/lib/render-value.ts#L738) ## Testing A test was added to ensure an element with `delegatesFocus` set to true has this attribute properly included in the rendered static markup.
🦋 Changeset detectedLatest commit: 6fc4f22 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: lit
natemoo-re
approved these changes
Feb 24, 2023
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@astrojs/lit’sserver.jsto properly render elements withshadowRootOptionsthat include setting delegatesFocus totrue.@lit-labs/ssrlatest implementation as found hereTesting
A test was added to ensure an element with
delegatesFocusset totruehas this attribute properly included in the rendered static markup.Docs
No documentation changes are needed. This is expected functionality that currently isn't properly supported by
@astrojs/lit.