-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): add --watch
to astro check
command
#6356
Conversation
🦋 Changeset detectedLatest commit: ba8c3b8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
7de9551
to
7a303fa
Compare
!preview check-watch |
|
230d21a
to
34d840d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
@@ -0,0 +1,2 @@ | |||
// Having a `tsconfig.json`, even empty speeds up the test massively since TypeScript does not have to look for one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good comment to add
Looks really good overall! Just left a few comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
15ababc
to
3a59e9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks for making the changes 💚 Looking forward for this to land!
Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
73040f2
to
6fdc02d
Compare
commit fbab73c Author: matthewp <matthewp@users.noreply.github.com> Date: Tue Mar 7 16:38:11 2023 +0000 [ci] format commit a206106 Author: Matthew Phillips <matthew@skypack.dev> Date: Tue Mar 7 11:35:54 2023 -0500 Expose the ssr manifest (#6435) * Expose the ssr manifest * Add changeset * Add types for virtual mod commit 2751584 Author: Princesseuh <Princesseuh@users.noreply.github.com> Date: Tue Mar 7 15:14:15 2023 +0000 [ci] format commit 694918a Author: Erika <3019731+Princesseuh@users.noreply.github.com> Date: Tue Mar 7 16:12:21 2023 +0100 Implement RFC "A core story for images" (#6344) * feat(assets): Add Vite plugin * feat(images): Set up Image component * fix(types): Attempt to fix type generation * Revert "fix(types): Attempt to fix type generation" This reverts commit 063aa27. * fix(image): Fix image types causing build to fail * feat(image): Implement client side part * feat(services): Allow arbitrary transforms parameters * fix(image): Fix paths and types * config(types): Update config types to provide completions for available services * feat(image): Add serving in dev * feat(image): Improve type error messages * refactor(image): Move sharp's parseParams to baseService * refactor(image): Skip work in dev for remote servies * feat(image): Add support for remote images * feat(image): Add squoosh service * chore: update export map * refactor(image): Abstract attributes handling by services * config(vercel): Remove test image service * feat(image): Support for relative images in Markdown (WIP) * feat(images): Add support for relative images in Markdown * feat(image): Update with RFC feedback * fix(image): Fix alt error on getImage * feat(image): Add support for assets validation through content collections * feat(image): Remove validateTransform * feat(image): Move to assets folder * fix(image): Fix package exports * feat(image): Add static imports references to virtual moduel * fix(image): Fix images from content collections not working when embedded * chore: lockfile * fix(markdown): Fix type * fix(images): Flag enhanced images behing an experimental flag * config(example): Update images example conifg * fix(image): Fix types * fix(image): Fix asset type for strict, allow arbritary input and output formats * chore: fix example check * feat(image): Emit assets for ESM imported images * Add initial core image tests (#6381) * feat(images): Make frontmatter extraction more generic than images for future * feat(image): Add support for building * fix(image): Fix types * fix(images): Fix compatibility with image integration * feat(images): Cuter generation stats * fix(images): Globals are unsafe, it turns out * fix(images): Only generate images if flag is enabled * fix(images): Only create `addStaticImage` in build * feat(images): Add SSR endpoint * fix(images): Only inject route in SSR * Add tests for SSR * Remove console.log * Updated lockfile * rename to satisfy the link gods * skip build tests for now * fix(images): Fix WASM files not being copied in dev * feat(images): Add quality presets * fix build tests running * Remove console.log * Add tests for getImage * Test local services * Test the content collections API * Add tests for quality * Skipping content collections test * feat(image): Add support for `~/assets` alias * test(image): Add tests for aliases in dev * Fix windows + content collections * test(image): Add tests for aliased images and images in Markdown * Fix markdown images being built * Should be posix join * Use the optimized image * fix test * Fixes windows smoke * fix(image): Nits * feat(images): Add automatic update for `env.d.ts` when experimental images are enabled * fix(images): Revert env.d.ts change if the user opted-out of the experimental image support * chore: remove bad image example project * feat(image): Rename `experimental.images` to `experimental.assets` * fix(images): Remove unused code in MDX integration * chore: Remove unrelated change * fix(images): Remove export from astro/components * Fix, esm import on Win * test(images): Add test for format * fix(images): Add `client-image.d.ts` to export map * chore: changeset * fix(images): Adjust with feedback, no more automatic refine, asset() -> image() * fix(images): Fix types * fix(images): Remove unnecessary spread * fix(images): Better types for parseUrl and transform * fix(images): Fix types * fix(images): Adjust from feedback * fix(images): Pass width and height through getHTMLAttributes even if they're not added by the uesr * fix(images): Recusirsively extract frontmatter assets * fix(images): Use a reduce instead * feat(images): Add support for data: URIs * chore: changeset * docs(images): Misc docs fixes * Update .changeset/gold-rocks-cry.md Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> * Update .changeset/gold-rocks-cry.md Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * Update packages/astro/src/@types/astro.ts Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> * Update packages/astro/src/assets/services/service.ts Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> * Update packages/astro/src/assets/services/service.ts Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> * Update packages/astro/src/assets/services/service.ts Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> * Update packages/astro/src/assets/types.ts Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> * Update packages/astro/src/assets/types.ts Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> --------- Co-authored-by: Matthew Phillips <matthew@skypack.dev> Co-authored-by: Matthew Phillips <matthew@matthewphillips.info> Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> commit 377530a Author: ematipico <ematipico@users.noreply.github.com> Date: Tue Mar 7 13:43:21 2023 +0000 [ci] format commit fe88f89 Author: Emanuele Stoppa <my.burning@gmail.com> Date: Tue Mar 7 13:41:24 2023 +0000 chore: use directive `@ts-expect-error` instead of `@ts-ignore` (#6429) commit e1858e6 Author: ematipico <ematipico@users.noreply.github.com> Date: Tue Mar 7 06:57:52 2023 +0000 [ci] format commit 75921b3 Author: Emanuele Stoppa <my.burning@gmail.com> Date: Tue Mar 7 06:55:41 2023 +0000 feat(cli): add `--watch` to `astro check` command (#6356) * feat(cli): add `--watch` to `astro check` command * chore: refactor in a leaner way, logic not changed * chore: lint * chore: revert changes in sync command * chore: tweak server settings * test: add one test case * chore: increase timeout * test: predictable testing * chore: add changeset * chore: code suggestions * code suggestions * chore: use directly `chokidar` * chore: tweak code * fix: open documents first * chore: disable test * chore: code suggestions * chore: code suggestions * Apply suggestions from code review Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com> * code suggestions * chore: rebase --------- Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com> commit 1291afc Author: Bjorn Lu <bjornlu.dev@gmail.com> Date: Tue Mar 7 14:50:34 2023 +0800 Fix changeset run (#6442) commit 00a0af7 Author: Bjorn Lu <bjornlu.dev@gmail.com> Date: Tue Mar 7 10:52:47 2023 +0800 Move benchmark package and update changeset config (#6433) commit af05a4f Author: Nate Moore <natemoo-re@users.noreply.github.com> Date: Mon Mar 6 14:06:33 2023 -0600 Update README.md (#6437) * Update README.md * Update README.md commit 8ebf4b7 Author: Nate Moore <natemoo-re@users.noreply.github.com> Date: Mon Mar 6 14:03:33 2023 -0600 chore: update branding assets (#6436) commit afbbc4d Author: Erika <3019731+Princesseuh@users.noreply.github.com> Date: Mon Mar 6 19:57:16 2023 +0100 Update compilation target for Node 16 (#6213) * config(esbuild): Update esbuild target to node16 * config(package): Update root package.json node engine * config(tsconfig): Update all the tsconfigs module and targets * chore: changeset * chore: remove unneeded file commit 18acae3 Author: Sarah Rainsberger <sarah@rainsberger.ca> Date: Mon Mar 6 14:36:40 2023 -0400 [error docs] update link for client-side scripts (#6423) commit 8b49d17 Author: ematipico <ematipico@users.noreply.github.com> Date: Mon Mar 6 17:03:18 2023 +0000 [ci] format commit a4a74ab Author: Emanuele Stoppa <my.burning@gmail.com> Date: Mon Mar 6 16:58:56 2023 +0000 feat(cli): add help flags to various commands (#6394) Co-authored-by: Happydev <81974850+MoustaphaDev@users.noreply.github.com> commit b087b83 Author: Dennis Morello <dennismorello@gmail.com> Date: Mon Mar 6 17:38:42 2023 +0100 Add getStaticPaths type helpers to infer params and props (#6150) * feat(astro): add InferGetStaticParamsType and InferGetStaticPropsType type helpers * chore(astro): added changeset commit 19fe4cb Author: Houston (Bot) <108291165+astrobot-houston@users.noreply.github.com> Date: Mon Mar 6 08:30:38 2023 -0800 [ci] release (#6414) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* chore: integration setup * feat: get markdoc contents * wip: expose Markdoc from integration * feat: basic Astro renderer in with-markdoc * fix: component render bug * deps: stringify-attributes * fix: render attributes to html * wip: play with separate markdoc config * wip: get dream API for file loader working * chore: unit tests * deps: graymatter * feat: addContentEntryType integration hook * deps: move to @astrojs/markdoc * feat: move Renderer to markdoc, get Content component! * wip: scaffold content types * deps: mdx * wip: move mdx to collection type API * refactor: move plain md to content entry type * refactor: pass file contents * oops, forgot to commit untracked * fix: markdoc.config loading * refactor: remove fallback loader * chore: remove unused dream file * deps: devalue, test fixture * test: entry and collections parse * play: make sure md also works * deps: add shiki for Code comp error * fix: remove "components" from tsconfig * chore: ignore `.astro` type error * fix: avoid import if no config present (prod build error) * fix: stop bundling markdoc for isTag * test: prod builds * test: content component dev and build * chore: Markdoc working! log * fix: ContentEntryType import * chore: remove content-types. Too early! * chore: remove unused options object * play: add docs example with Aside and Since ported * chore: with-markdoc strictNullChecks * chore: unused file * feat: allow Render type injection * feat: content prop types for markdoc! * chore: clean up Markdoc starter to essentials * chore: unused style tag * chore: remove unused deps * fix: glob for single content extension * chore: remove unused fixture dep * chore: remove markdoc.config loader * docs: update example README * docs: @astrojs/markdoc README intro * fix: line endings in test * docs: add usage and examples to Markdoc README * docs: change with-markdoc title * docs: README edits * refactor: clean up astroNode * nit: reorder type import * docs: add note on Aside src * chore: changeset * nit: 0.0.0 to avoid version bump * fix: lock * refactor: remove unneeded async * fix: import types from @astrojs/markdoc * fix: type inferencing in preview * fix: remove unneeded html-escaper * deps: remove html-escaper * feat: support `.md` overrides for content collections * chore: mdoc -> md * feat: generate `.md` types override * Revert "feat: support `.md` overrides for content collections" This reverts commit c06f83e. * Squashed commit of `markdoc-poc` commit bd0dd9d Author: bholmesdev <hey@bholmes.dev> Date: Wed Feb 15 09:43:04 2023 -0500 Revert "feat: support `.md` overrides for content collections" This reverts commit c06f83e. commit 5b9a1f3 Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 13:48:56 2023 -0500 feat: generate `.md` types override commit e464ae8 Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 12:56:11 2023 -0500 chore: mdoc -> md commit b74fd6a Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 12:56:01 2023 -0500 feat: support `.md` overrides for content collections commit bdcc18a Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 12:30:48 2023 -0500 deps: remove html-escaper commit f44b57f Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 12:30:42 2023 -0500 fix: remove unneeded html-escaper commit fb79194 Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 12:08:04 2023 -0500 fix: type inferencing in preview commit 0c05034 Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 11:32:19 2023 -0500 fix: import types from @astrojs/markdoc commit 57e741a Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 11:28:33 2023 -0500 refactor: remove unneeded async commit b19d854 Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 10:26:20 2023 -0500 fix: lock commit b1083a1 Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 10:19:50 2023 -0500 nit: 0.0.0 to avoid version bump commit 71891eb Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 09:33:27 2023 -0500 chore: changeset commit 444752a Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 09:30:10 2023 -0500 docs: add note on Aside src commit 619d4b3 Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 09:25:56 2023 -0500 nit: reorder type import commit e914da0 Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 09:25:38 2023 -0500 refactor: clean up astroNode commit 2dfc226 Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 09:08:56 2023 -0500 docs: README edits commit 3c7b85c Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 09:07:29 2023 -0500 docs: change with-markdoc title commit 29cdea9 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 18:29:10 2023 -0500 docs: add usage and examples to Markdoc README commit e397a80 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 18:18:54 2023 -0500 fix: line endings in test commit f9ebf59 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 18:09:15 2023 -0500 docs: @astrojs/markdoc README intro commit 7800e9c Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 18:08:07 2023 -0500 docs: update example README commit f0b900a Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 18:04:34 2023 -0500 chore: remove markdoc.config loader commit 3f040e4 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 17:58:52 2023 -0500 chore: remove unused fixture dep commit b2ea6c2 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 17:58:25 2023 -0500 fix: glob for single content extension commit f4e171c Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 15:10:39 2023 -0500 chore: remove unused deps commit d9095d0 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 15:10:31 2023 -0500 chore: unused style tag commit a5435f1 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 15:08:52 2023 -0500 chore: clean up Markdoc starter to essentials commit 815e2f2 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 14:13:02 2023 -0500 feat: content prop types for markdoc! commit 8bcd23c Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 14:05:40 2023 -0500 feat: allow Render type injection commit cdb7e9e Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 14:04:37 2023 -0500 chore: unused file commit 0df33ea Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 14:04:31 2023 -0500 chore: with-markdoc strictNullChecks commit 377c6d7 Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 17:39:35 2023 -0500 play: add docs example with Aside and Since ported commit f9f8112 Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 09:22:47 2023 -0500 chore: remove unused options object commit c9a66bf Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 09:18:27 2023 -0500 chore: remove content-types. Too early! commit 67f49e8 Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 09:18:20 2023 -0500 fix: ContentEntryType import commit 9b93d81 Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 09:10:06 2023 -0500 chore: Markdoc working! log commit 90f7764 Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 09:09:58 2023 -0500 test: content component dev and build commit 14559f6 Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 09:01:10 2023 -0500 test: prod builds commit a0dcbff Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 09:01:04 2023 -0500 fix: stop bundling markdoc for isTag commit cb19048 Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 09:00:53 2023 -0500 fix: avoid import if no config present (prod build error) commit bda8295 Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 09:00:33 2023 -0500 chore: ignore `.astro` type error commit 28a6d79 Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 09:00:12 2023 -0500 fix: remove "components" from tsconfig commit 0297bb7 Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 09:00:01 2023 -0500 deps: add shiki for Code comp error commit e4f141e Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 08:45:37 2023 -0500 play: make sure md also works commit dfdb35f Author: bholmesdev <hey@bholmes.dev> Date: Thu Feb 9 13:25:18 2023 -0500 test: entry and collections parse commit eaf4994 Author: bholmesdev <hey@bholmes.dev> Date: Thu Feb 9 13:25:07 2023 -0500 deps: devalue, test fixture commit 3f71932 Author: bholmesdev <hey@bholmes.dev> Date: Thu Feb 9 13:24:47 2023 -0500 chore: remove unused dream file commit b182686 Author: bholmesdev <hey@bholmes.dev> Date: Thu Feb 9 12:29:32 2023 -0500 refactor: remove fallback loader commit 0540d70 Author: bholmesdev <hey@bholmes.dev> Date: Thu Feb 9 12:26:21 2023 -0500 fix: markdoc.config loading commit 575dadf Author: bholmesdev <hey@bholmes.dev> Date: Thu Feb 9 12:16:18 2023 -0500 oops, forgot to commit untracked commit 9746a97 Author: bholmesdev <hey@bholmes.dev> Date: Thu Feb 9 12:16:02 2023 -0500 refactor: pass file contents commit 534a658 Author: bholmesdev <hey@bholmes.dev> Date: Thu Feb 9 12:13:38 2023 -0500 refactor: move plain md to content entry type commit 24df79b Author: bholmesdev <hey@bholmes.dev> Date: Wed Feb 8 15:51:44 2023 -0500 wip: move mdx to collection type API commit cc44e4f Author: bholmesdev <hey@bholmes.dev> Date: Wed Feb 8 15:50:52 2023 -0500 deps: mdx commit c30c1b3 Author: bholmesdev <hey@bholmes.dev> Date: Wed Feb 8 10:10:39 2023 -0500 wip: scaffold content types commit 2487aed Author: bholmesdev <hey@bholmes.dev> Date: Wed Feb 8 09:53:35 2023 -0500 feat: move Renderer to markdoc, get Content component! commit 44faff9 Author: bholmesdev <hey@bholmes.dev> Date: Wed Feb 8 09:53:06 2023 -0500 deps: move to @astrojs/markdoc commit bef2690 Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 7 16:01:34 2023 -0500 feat: addContentEntryType integration hook commit 508568f Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 7 16:00:42 2023 -0500 deps: graymatter commit cb70602 Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 7 14:00:27 2023 -0500 chore: unit tests commit 545246d Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 7 14:00:23 2023 -0500 wip: get dream API for file loader working commit 97664e0 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 6 18:09:23 2023 -0500 wip: play with separate markdoc config commit c5d8a33 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 6 17:04:22 2023 -0500 fix: render attributes to html commit 82e30a0 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 6 17:04:14 2023 -0500 deps: stringify-attributes commit b72ba61 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 6 16:33:27 2023 -0500 fix: component render bug commit 59f1e5c Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 6 16:11:15 2023 -0500 feat: basic Astro renderer in with-markdoc commit de15a72 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 6 16:11:01 2023 -0500 wip: expose Markdoc from integration commit 83bfe44 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 6 11:21:17 2023 -0500 feat: get markdoc contents commit 6f50068 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 6 11:13:57 2023 -0500 chore: integration setup * Squashed commit of `markdoc-poc` commit bd0dd9d Author: bholmesdev <hey@bholmes.dev> Date: Wed Feb 15 09:43:04 2023 -0500 Revert "feat: support `.md` overrides for content collections" This reverts commit c06f83e. commit 5b9a1f3 Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 13:48:56 2023 -0500 feat: generate `.md` types override commit e464ae8 Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 12:56:11 2023 -0500 chore: mdoc -> md commit b74fd6a Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 12:56:01 2023 -0500 feat: support `.md` overrides for content collections commit bdcc18a Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 12:30:48 2023 -0500 deps: remove html-escaper commit f44b57f Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 12:30:42 2023 -0500 fix: remove unneeded html-escaper commit fb79194 Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 12:08:04 2023 -0500 fix: type inferencing in preview commit 0c05034 Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 11:32:19 2023 -0500 fix: import types from @astrojs/markdoc commit 57e741a Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 11:28:33 2023 -0500 refactor: remove unneeded async commit b19d854 Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 10:26:20 2023 -0500 fix: lock commit b1083a1 Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 10:19:50 2023 -0500 nit: 0.0.0 to avoid version bump commit 71891eb Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 09:33:27 2023 -0500 chore: changeset commit 444752a Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 09:30:10 2023 -0500 docs: add note on Aside src commit 619d4b3 Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 09:25:56 2023 -0500 nit: reorder type import commit e914da0 Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 09:25:38 2023 -0500 refactor: clean up astroNode commit 2dfc226 Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 09:08:56 2023 -0500 docs: README edits commit 3c7b85c Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 14 09:07:29 2023 -0500 docs: change with-markdoc title commit 29cdea9 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 18:29:10 2023 -0500 docs: add usage and examples to Markdoc README commit e397a80 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 18:18:54 2023 -0500 fix: line endings in test commit f9ebf59 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 18:09:15 2023 -0500 docs: @astrojs/markdoc README intro commit 7800e9c Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 18:08:07 2023 -0500 docs: update example README commit f0b900a Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 18:04:34 2023 -0500 chore: remove markdoc.config loader commit 3f040e4 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 17:58:52 2023 -0500 chore: remove unused fixture dep commit b2ea6c2 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 17:58:25 2023 -0500 fix: glob for single content extension commit f4e171c Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 15:10:39 2023 -0500 chore: remove unused deps commit d9095d0 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 15:10:31 2023 -0500 chore: unused style tag commit a5435f1 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 15:08:52 2023 -0500 chore: clean up Markdoc starter to essentials commit 815e2f2 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 14:13:02 2023 -0500 feat: content prop types for markdoc! commit 8bcd23c Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 14:05:40 2023 -0500 feat: allow Render type injection commit cdb7e9e Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 14:04:37 2023 -0500 chore: unused file commit 0df33ea Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 13 14:04:31 2023 -0500 chore: with-markdoc strictNullChecks commit 377c6d7 Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 17:39:35 2023 -0500 play: add docs example with Aside and Since ported commit f9f8112 Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 09:22:47 2023 -0500 chore: remove unused options object commit c9a66bf Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 09:18:27 2023 -0500 chore: remove content-types. Too early! commit 67f49e8 Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 09:18:20 2023 -0500 fix: ContentEntryType import commit 9b93d81 Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 09:10:06 2023 -0500 chore: Markdoc working! log commit 90f7764 Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 09:09:58 2023 -0500 test: content component dev and build commit 14559f6 Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 09:01:10 2023 -0500 test: prod builds commit a0dcbff Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 09:01:04 2023 -0500 fix: stop bundling markdoc for isTag commit cb19048 Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 09:00:53 2023 -0500 fix: avoid import if no config present (prod build error) commit bda8295 Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 09:00:33 2023 -0500 chore: ignore `.astro` type error commit 28a6d79 Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 09:00:12 2023 -0500 fix: remove "components" from tsconfig commit 0297bb7 Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 09:00:01 2023 -0500 deps: add shiki for Code comp error commit e4f141e Author: bholmesdev <hey@bholmes.dev> Date: Fri Feb 10 08:45:37 2023 -0500 play: make sure md also works commit dfdb35f Author: bholmesdev <hey@bholmes.dev> Date: Thu Feb 9 13:25:18 2023 -0500 test: entry and collections parse commit eaf4994 Author: bholmesdev <hey@bholmes.dev> Date: Thu Feb 9 13:25:07 2023 -0500 deps: devalue, test fixture commit 3f71932 Author: bholmesdev <hey@bholmes.dev> Date: Thu Feb 9 13:24:47 2023 -0500 chore: remove unused dream file commit b182686 Author: bholmesdev <hey@bholmes.dev> Date: Thu Feb 9 12:29:32 2023 -0500 refactor: remove fallback loader commit 0540d70 Author: bholmesdev <hey@bholmes.dev> Date: Thu Feb 9 12:26:21 2023 -0500 fix: markdoc.config loading commit 575dadf Author: bholmesdev <hey@bholmes.dev> Date: Thu Feb 9 12:16:18 2023 -0500 oops, forgot to commit untracked commit 9746a97 Author: bholmesdev <hey@bholmes.dev> Date: Thu Feb 9 12:16:02 2023 -0500 refactor: pass file contents commit 534a658 Author: bholmesdev <hey@bholmes.dev> Date: Thu Feb 9 12:13:38 2023 -0500 refactor: move plain md to content entry type commit 24df79b Author: bholmesdev <hey@bholmes.dev> Date: Wed Feb 8 15:51:44 2023 -0500 wip: move mdx to collection type API commit cc44e4f Author: bholmesdev <hey@bholmes.dev> Date: Wed Feb 8 15:50:52 2023 -0500 deps: mdx commit c30c1b3 Author: bholmesdev <hey@bholmes.dev> Date: Wed Feb 8 10:10:39 2023 -0500 wip: scaffold content types commit 2487aed Author: bholmesdev <hey@bholmes.dev> Date: Wed Feb 8 09:53:35 2023 -0500 feat: move Renderer to markdoc, get Content component! commit 44faff9 Author: bholmesdev <hey@bholmes.dev> Date: Wed Feb 8 09:53:06 2023 -0500 deps: move to @astrojs/markdoc commit bef2690 Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 7 16:01:34 2023 -0500 feat: addContentEntryType integration hook commit 508568f Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 7 16:00:42 2023 -0500 deps: graymatter commit cb70602 Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 7 14:00:27 2023 -0500 chore: unit tests commit 545246d Author: bholmesdev <hey@bholmes.dev> Date: Tue Feb 7 14:00:23 2023 -0500 wip: get dream API for file loader working commit 97664e0 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 6 18:09:23 2023 -0500 wip: play with separate markdoc config commit c5d8a33 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 6 17:04:22 2023 -0500 fix: render attributes to html commit 82e30a0 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 6 17:04:14 2023 -0500 deps: stringify-attributes commit b72ba61 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 6 16:33:27 2023 -0500 fix: component render bug commit 59f1e5c Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 6 16:11:15 2023 -0500 feat: basic Astro renderer in with-markdoc commit de15a72 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 6 16:11:01 2023 -0500 wip: expose Markdoc from integration commit 83bfe44 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 6 11:21:17 2023 -0500 feat: get markdoc contents commit 6f50068 Author: bholmesdev <hey@bholmes.dev> Date: Mon Feb 6 11:13:57 2023 -0500 chore: integration setup * feat: add `--perf` flag to skip md plugins * wip: performance pkg with md fixture * refactor: move rendering to util * refactor: generate posts instead of commiting * deps: npm-run-all * chore: mdoc and mdx fixtures * chore: remove generated files from git * chore: lockfile * chore: remove .astro types from remote * refactor: --perf -> --internal-ci-perf * chore: log ext and directory on write * refactor: --perf -> env var * feat: add perf benchmark check to mdx * refactor: isPerfBenchmark * chore: refine generated ignore * feat: test simple and with-components cases * chore: remove old --internal-ci reference * refactor: ASTRO_CI_PERFORMANCE_RUN -> ASTRO_PERFORMANCE_BENCHMARK * chore: remove accidental file * feat: add react-component render benchmark * chore: add `--format` flag to benchmark * refactor: move markdoc transform to build time * docs: only used in content collections Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * chore: use Markdoc terms for transform * refactor: remove Markdoc export * refactor: remove advanced component API * test: update fixture to match new config * chore: with-markdoc filetree * docs: add "exclusively" to README * docs: query for -> query your collection * docs: update config to new Markdoc options * docs: astro-ui-frameworks -> astro-components * edit: add client component instructions * nit: add "today" to imply future support * docs: add separate HTML and component examples * fix: inconsistent tabs v spaces * fix: indentation * deps: zod * chore: check components are capitalized names * chore: raise error if no matching component found * chore: hand `mjs` highlighting in error overlay * chore: validate tags and nodes * refactor: use MarkdocError on render errors * fix: handle possible cache miss * chore: use error hint * test: update Markdoc node config test * chore: clarify Markdoc config * docs: reshuffle note * chore: update to `nodes` rec * docs: clarify Markdoc attributes * docs: add editor integration * chore: update example coding challenge * chore: update DocsContent comments * fix: cant find zod for some reason * fix: potentially unreliable cache * chore: remove revealSecret from ex * wip: forward slash?? * fix: forward slash. * chore: lint * chore: ignore statements * chore: clarify semi-private hooks * docs: with-mdx -> with-markdoc Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * nit: don't capitalize cc Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * docs: ::: Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * nit: remove IFFE * chore: remove accidental changelog * nit: attempt pathToFileURL * nit: tested if * fix: smartypants should be avoided in benchmark! * nit: remove `any` * nit: extract component zod obj * fix: move validateComponents to render comp * nit: remove unused return * nit: move shiki highlighter consts to outer scope * nit: remove `any` from mdx * refactor: add type defs for private integration hooks * fix: type error in mdx defaults * fix: broke extendMarkdownConfig, oops! * Revert "nit: attempt pathToFileURL" This reverts commit 45fac99. * fix: only validate when components is defined * fix: remove types from git * fix: migrate mdoc perf benchmark to new config * chore: delete more sneaky types * docs: add usage to changeset * docs: update config example in README * docs: add manual rendering instructions * Update examples/with-markdoc/README.md Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * docs: reorder configuration options * docs: "see the next section" * chore: add numPosts as a benchmark flag * chore: bump to minor changesets for MDX * chore: update TODO docs links * docs: update component key naming and node instr * docs: redraft markdoc runtime config intro * Squashed commit of the following: commit fbab73c Author: matthewp <matthewp@users.noreply.github.com> Date: Tue Mar 7 16:38:11 2023 +0000 [ci] format commit a206106 Author: Matthew Phillips <matthew@skypack.dev> Date: Tue Mar 7 11:35:54 2023 -0500 Expose the ssr manifest (#6435) * Expose the ssr manifest * Add changeset * Add types for virtual mod commit 2751584 Author: Princesseuh <Princesseuh@users.noreply.github.com> Date: Tue Mar 7 15:14:15 2023 +0000 [ci] format commit 694918a Author: Erika <3019731+Princesseuh@users.noreply.github.com> Date: Tue Mar 7 16:12:21 2023 +0100 Implement RFC "A core story for images" (#6344) * feat(assets): Add Vite plugin * feat(images): Set up Image component * fix(types): Attempt to fix type generation * Revert "fix(types): Attempt to fix type generation" This reverts commit 063aa27. * fix(image): Fix image types causing build to fail * feat(image): Implement client side part * feat(services): Allow arbitrary transforms parameters * fix(image): Fix paths and types * config(types): Update config types to provide completions for available services * feat(image): Add serving in dev * feat(image): Improve type error messages * refactor(image): Move sharp's parseParams to baseService * refactor(image): Skip work in dev for remote servies * feat(image): Add support for remote images * feat(image): Add squoosh service * chore: update export map * refactor(image): Abstract attributes handling by services * config(vercel): Remove test image service * feat(image): Support for relative images in Markdown (WIP) * feat(images): Add support for relative images in Markdown * feat(image): Update with RFC feedback * fix(image): Fix alt error on getImage * feat(image): Add support for assets validation through content collections * feat(image): Remove validateTransform * feat(image): Move to assets folder * fix(image): Fix package exports * feat(image): Add static imports references to virtual moduel * fix(image): Fix images from content collections not working when embedded * chore: lockfile * fix(markdown): Fix type * fix(images): Flag enhanced images behing an experimental flag * config(example): Update images example conifg * fix(image): Fix types * fix(image): Fix asset type for strict, allow arbritary input and output formats * chore: fix example check * feat(image): Emit assets for ESM imported images * Add initial core image tests (#6381) * feat(images): Make frontmatter extraction more generic than images for future * feat(image): Add support for building * fix(image): Fix types * fix(images): Fix compatibility with image integration * feat(images): Cuter generation stats * fix(images): Globals are unsafe, it turns out * fix(images): Only generate images if flag is enabled * fix(images): Only create `addStaticImage` in build * feat(images): Add SSR endpoint * fix(images): Only inject route in SSR * Add tests for SSR * Remove console.log * Updated lockfile * rename to satisfy the link gods * skip build tests for now * fix(images): Fix WASM files not being copied in dev * feat(images): Add quality presets * fix build tests running * Remove console.log * Add tests for getImage * Test local services * Test the content collections API * Add tests for quality * Skipping content collections test * feat(image): Add support for `~/assets` alias * test(image): Add tests for aliases in dev * Fix windows + content collections * test(image): Add tests for aliased images and images in Markdown * Fix markdown images being built * Should be posix join * Use the optimized image * fix test * Fixes windows smoke * fix(image): Nits * feat(images): Add automatic update for `env.d.ts` when experimental images are enabled * fix(images): Revert env.d.ts change if the user opted-out of the experimental image support * chore: remove bad image example project * feat(image): Rename `experimental.images` to `experimental.assets` * fix(images): Remove unused code in MDX integration * chore: Remove unrelated change * fix(images): Remove export from astro/components * Fix, esm import on Win * test(images): Add test for format * fix(images): Add `client-image.d.ts` to export map * chore: changeset * fix(images): Adjust with feedback, no more automatic refine, asset() -> image() * fix(images): Fix types * fix(images): Remove unnecessary spread * fix(images): Better types for parseUrl and transform * fix(images): Fix types * fix(images): Adjust from feedback * fix(images): Pass width and height through getHTMLAttributes even if they're not added by the uesr * fix(images): Recusirsively extract frontmatter assets * fix(images): Use a reduce instead * feat(images): Add support for data: URIs * chore: changeset * docs(images): Misc docs fixes * Update .changeset/gold-rocks-cry.md Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> * Update .changeset/gold-rocks-cry.md Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * Update packages/astro/src/@types/astro.ts Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> * Update packages/astro/src/assets/services/service.ts Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> * Update packages/astro/src/assets/services/service.ts Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> * Update packages/astro/src/assets/services/service.ts Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> * Update packages/astro/src/assets/types.ts Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> * Update packages/astro/src/assets/types.ts Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> --------- Co-authored-by: Matthew Phillips <matthew@skypack.dev> Co-authored-by: Matthew Phillips <matthew@matthewphillips.info> Co-authored-by: Chris Swithinbank <swithinbank@gmail.com> Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> commit 377530a Author: ematipico <ematipico@users.noreply.github.com> Date: Tue Mar 7 13:43:21 2023 +0000 [ci] format commit fe88f89 Author: Emanuele Stoppa <my.burning@gmail.com> Date: Tue Mar 7 13:41:24 2023 +0000 chore: use directive `@ts-expect-error` instead of `@ts-ignore` (#6429) commit e1858e6 Author: ematipico <ematipico@users.noreply.github.com> Date: Tue Mar 7 06:57:52 2023 +0000 [ci] format commit 75921b3 Author: Emanuele Stoppa <my.burning@gmail.com> Date: Tue Mar 7 06:55:41 2023 +0000 feat(cli): add `--watch` to `astro check` command (#6356) * feat(cli): add `--watch` to `astro check` command * chore: refactor in a leaner way, logic not changed * chore: lint * chore: revert changes in sync command * chore: tweak server settings * test: add one test case * chore: increase timeout * test: predictable testing * chore: add changeset * chore: code suggestions * code suggestions * chore: use directly `chokidar` * chore: tweak code * fix: open documents first * chore: disable test * chore: code suggestions * chore: code suggestions * Apply suggestions from code review Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com> * code suggestions * chore: rebase --------- Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com> commit 1291afc Author: Bjorn Lu <bjornlu.dev@gmail.com> Date: Tue Mar 7 14:50:34 2023 +0800 Fix changeset run (#6442) commit 00a0af7 Author: Bjorn Lu <bjornlu.dev@gmail.com> Date: Tue Mar 7 10:52:47 2023 +0800 Move benchmark package and update changeset config (#6433) commit af05a4f Author: Nate Moore <natemoo-re@users.noreply.github.com> Date: Mon Mar 6 14:06:33 2023 -0600 Update README.md (#6437) * Update README.md * Update README.md commit 8ebf4b7 Author: Nate Moore <natemoo-re@users.noreply.github.com> Date: Mon Mar 6 14:03:33 2023 -0600 chore: update branding assets (#6436) commit afbbc4d Author: Erika <3019731+Princesseuh@users.noreply.github.com> Date: Mon Mar 6 19:57:16 2023 +0100 Update compilation target for Node 16 (#6213) * config(esbuild): Update esbuild target to node16 * config(package): Update root package.json node engine * config(tsconfig): Update all the tsconfigs module and targets * chore: changeset * chore: remove unneeded file commit 18acae3 Author: Sarah Rainsberger <sarah@rainsberger.ca> Date: Mon Mar 6 14:36:40 2023 -0400 [error docs] update link for client-side scripts (#6423) commit 8b49d17 Author: ematipico <ematipico@users.noreply.github.com> Date: Mon Mar 6 17:03:18 2023 +0000 [ci] format commit a4a74ab Author: Emanuele Stoppa <my.burning@gmail.com> Date: Mon Mar 6 16:58:56 2023 +0000 feat(cli): add help flags to various commands (#6394) Co-authored-by: Happydev <81974850+MoustaphaDev@users.noreply.github.com> commit b087b83 Author: Dennis Morello <dennismorello@gmail.com> Date: Mon Mar 6 17:38:42 2023 +0100 Add getStaticPaths type helpers to infer params and props (#6150) * feat(astro): add InferGetStaticParamsType and InferGetStaticPropsType type helpers * chore(astro): added changeset commit 19fe4cb Author: Houston (Bot) <108291165+astrobot-houston@users.noreply.github.com> Date: Mon Mar 6 08:30:38 2023 -0800 [ci] release (#6414) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Revert "Squashed commit of the following:" This reverts commit fbe129b. * feat: add mdx backwards compat to make nonbreaking * chore: add comment on error code * Revert "chore: bump to minor changesets for MDX" This reverts commit 3e99783. --------- Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Changes
See withastro/roadmap#473 for more context.
This PR adds a new argument to the command
astro check
called--watch
.Coding-wise, I refactored the file, but the command's core logic is the same.
This PR takes advantage of the
watcher
provided byvite
.vite
useschokidar
as a file watcher. When a file is added/modified, we upsert the document and run the checker. When a file is deleted -unlink
- we remove and rerun the checker.I had to change the part where we created the
vite
configuration. Passingwatch.ignore: undefined
was breaking the watcher.Testing
I added a new test case to make sure we receive an error if we modify a file that was previously valid.
I also tested the feature manually, locally.
Docs
Requires documentation