Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slot fallbacks unexpectedly showing up in some cases #6819

Merged
merged 6 commits into from Apr 12, 2023

Conversation

MoustaphaDev
Copy link
Member

@MoustaphaDev MoustaphaDev commented Apr 11, 2023

Changes

Fix #6788

Check if there's no slotted content before showing the fallback

Testing

Check if the fallback content doesn't appear next to the slotted content

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2023

🦋 Changeset detected

Latest commit: fba93ef

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Apr 11, 2023
@MoustaphaDev MoustaphaDev changed the title Fix slot fallbacks unexpectedly showing in some cases Fix slot fallbacks unexpectedly showing up in some cases Apr 11, 2023
@MoustaphaDev MoustaphaDev marked this pull request as ready for review April 11, 2023 18:24
@matthewp
Copy link
Contributor

Oops, this was my mistake, thanks for the fix!

@matthewp matthewp merged commit 76dd53e into main Apr 12, 2023
14 checks passed
@matthewp matthewp deleted the fix-solt-fallbacks branch April 12, 2023 12:23
@astrobot-houston astrobot-houston mentioned this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slot fallback is showing even when passing in a slot prop.
3 participants