Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mdx): Add support for turning ![]() into <Image> #6824

Merged
merged 8 commits into from
Apr 13, 2023

Conversation

Princesseuh
Copy link
Member

Changes

With this PR, we now have optimized images in Markdown, MDX and Markdoc! Wow!

Fix #6777

Testing

Added a test

Docs

withastro/docs#3032

@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2023

🦋 Changeset detected

Latest commit: 50daa43

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) feat: markdown Related to Markdown (scope) labels Apr 12, 2023
Copy link
Contributor

@jasikpark jasikpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, i'm excited!

@Princesseuh Princesseuh merged commit 2511d58 into main Apr 13, 2023
@Princesseuh Princesseuh deleted the feat/mdx-images branch April 13, 2023 09:54
@astrobot-houston astrobot-houston mentioned this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: markdown Related to Markdown (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

![]() with astro:assets doesn't work in MDX
5 participants