Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tsconfig alias baseUrl handling for "." and ".." imports #6920

Merged
merged 1 commit into from Apr 27, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Apr 27, 2023

Changes

fix #6901

We were aliasing import "." and import ".." and prepending the baseUrl before which shouldn't happen. This PR updates the regex to ignore . and ...

Testing

Added a new test using those imports.

Docs

n/a. bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023

🦋 Changeset detected

Latest commit: 4eabd80

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Apr 27, 2023
@bluwy bluwy merged commit b890425 into main Apr 27, 2023
14 checks passed
@bluwy bluwy deleted the fix-alias-dot branch April 27, 2023 10:30
@astrobot-houston astrobot-houston mentioned this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build not working on Astro 2.3.0, npm run dev works as before
2 participants