select random ports if defaults are taken #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bcaf089 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/astro-www/Cjv2z7Lg2rdtP6VvmSP9moAkdE9V |
FredKSchott
approved these changes
Jul 14, 2021
There was a problem hiding this comment.
LGTM, really appreciate the contribution! Will leave this for @natemoo-re or @matthewp to also review and then merge
natemoo-re
approved these changes
Jul 14, 2021
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* select random port if default ports are taken * add changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #429.
Changes
This adds support for multiple Astro dev servers running simultaneously. Previously, trying to start a second server errored out because the fixed default ports were already in use. Now, when the default ports are in use, a random port is chosen.
Testing
I've tested this manually by running two of the examples in the repo at the same time. Not sure if this can be automatically tested against, but if it needs to be, I would like some pointers.
Docs
Bug fix only.